From: Daniel Vetter Subject: Re: [PATCH 2/2] drm/i915: Adding a warning to FBC description Date: Tue, 29 Jan 2013 09:49:13 +0100 Message-ID: <20130129084913.GE14766@phenom.ffwll.local> References: <1359415936-2732-1-git-send-email-ben@bwidawsk.net> <1359415936-2732-2-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f171.google.com (mail-we0-f171.google.com [74.125.82.171]) by gabe.freedesktop.org (Postfix) with ESMTP id 67CADE61B3 for ; Tue, 29 Jan 2013 00:47:05 -0800 (PST) Received: by mail-we0-f171.google.com with SMTP id u54so126281wey.16 for ; Tue, 29 Jan 2013 00:47:04 -0800 (PST) Content-Disposition: inline In-Reply-To: <1359415936-2732-2-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Jan 28, 2013 at 03:32:16PM -0800, Ben Widawsky wrote: > It should only be used with caution... > > Signed-off-by: Ben Widawsky Isn't that like the general assumption of these module parameters that they can have pretty massive bad side-effects? Meaning I'm routinely checking these already anyway in bug reports, same for non-standard rc6 settings. -Daniel > --- > drivers/gpu/drm/i915/i915_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index 9cc8f87..912db3a 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -76,6 +76,7 @@ int i915_enable_fbc __read_mostly = -1; > module_param_named(i915_enable_fbc, i915_enable_fbc, int, 0600); > MODULE_PARM_DESC(i915_enable_fbc, > "Enable frame buffer compression for power savings " > + "WARNING: FBC has been implicated in hangs over the years, and should likely be left to the default value. " > "(default: -1 (use per-chip default))"); > > unsigned int i915_lvds_downclock __read_mostly = 0; > -- > 1.8.1.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch