From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915: Error state should print /sys/kernel/debug Date: Tue, 29 Jan 2013 09:54:18 +0100 Message-ID: <20130129085418.GF14766@phenom.ffwll.local> References: <1359415936-2732-1-git-send-email-ben@bwidawsk.net> <20130129084112.GG6187@dyon.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f172.google.com (mail-we0-f172.google.com [74.125.82.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 1345DE6128 for ; Tue, 29 Jan 2013 00:52:09 -0800 (PST) Received: by mail-we0-f172.google.com with SMTP id x10so129324wey.17 for ; Tue, 29 Jan 2013 00:52:09 -0800 (PST) Content-Disposition: inline In-Reply-To: <20130129084112.GG6187@dyon.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Damien Lespiau Cc: Ben Widawsky , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Jan 29, 2013 at 08:41:12AM +0000, Damien Lespiau wrote: > On Mon, Jan 28, 2013 at 03:32:15PM -0800, Ben Widawsky wrote: > > /sys/kernel/debug has more or less been the standard location of debugfs > > for several years now. Other parts of DRM already use this location, so > > we should as well. > > > > Signed-off-by: Ben Widawsky > > Reviewed-by: Damien Lespiau Queued for -next, thanks for the patch. Oh and fixed up a bikeshed from checkpatch.pl while applying: Applying: drm/i915: Error state should print /sys/kernel/debug WARNING: line over 80 characters #22: FILE: drivers/gpu/drm/i915/i915_irq.c:1308: + DRM_INFO("capturing error event; look for more information in /sys/kernel/debug/dri/%d/i915_error_state\n", total: 0 errors, 1 warnings, 8 lines checked Yeah, I've added that OCD thing to my patch apply pipeline, let's see how much fun it is ;-) -Daniel > > -- > Damien > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch