From: Wolfgang Denk <wd@denx.de>
Date: Tue, 29 Jan 2013 14:52:09 +0100
Subject: [U-Boot] [PATCH V2 2/7] omap3: allow dynamic selection of
	gfx_format
In-Reply-To: <1359463349-11649-3-git-send-email-nikita@compulab.co.il>
References: <1359463349-11649-1-git-send-email-nikita@compulab.co.il>
	<1359463349-11649-3-git-send-email-nikita@compulab.co.il>
Message-ID: <20130129135209.BEC252A08AC@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Nikita Kiryanov,

In message <1359463349-11649-3-git-send-email-nikita@compulab.co.il> you wrote:
> Currently the value of gfx_format is hardcoded into
> omap3_dss_panel_config(). Make it a field in struct panel_config, and
> update existing structs to set this field to the value that was originally hard
> coded.

It is not exactly clear to me what exactly this is needed for?  Are
you just adding dead code?  if not, then please explain this in the
commit message.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The word "fit", as I understand it, means "appropriate to a purpose",
and I would say the body of the Dean is supremely appropriate to  the
purpose of sitting around all day and eating big heavy meals.
                                 - Terry Pratchett, _Moving Pictures_