From: Wim Van Sebroeck Subject: Re: [PATCH] watchdog: da9055_wdt needs to select WATCHDOG_CORE Date: Wed, 30 Jan 2013 20:23:30 +0100 Message-ID: <20130130192330.GD20100@spo001.leaseweb.com> References: <20130129000610.22f0ebd13431c59c5dc8cf3d@canb.auug.org.au> <5106A77C.2050400@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <5106A77C.2050400@infradead.org> Sender: linux-kernel-owner@vger.kernel.org To: Randy Dunlap Cc: Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, David Dajun Chen , linux-watchdog@vger.kernel.org List-Id: linux-next.vger.kernel.org Hi Randy, > From: Randy Dunlap > > DA9055_WATCHDOG needs to select WATCHDOG_CORE so that it will > build cleanly. Fixes these build errors: > > da9055_wdt.c:(.text+0xe9bc7): undefined reference to `watchdog_unregister_device' > da9055_wdt.c:(.text+0xe9f4b): undefined reference to `watchdog_register_device' > > Signed-off-by: Randy Dunlap > Cc: David Dajun Chen > Cc: Wim Van Sebroeck > Cc: linux-watchdog@vger.kernel.org > --- > drivers/watchdog/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > Found in linux-next, but also applies to mainline. > > --- linux-next-20130128.orig/drivers/watchdog/Kconfig > +++ linux-next-20130128/drivers/watchdog/Kconfig > @@ -79,6 +79,7 @@ config DA9052_WATCHDOG > config DA9055_WATCHDOG > tristate "Dialog Semiconductor DA9055 Watchdog" > depends on MFD_DA9055 > + select WATCHDOG_CORE > help > If you say yes here you get support for watchdog on the Dialog > Semiconductor DA9055 PMIC. Added to linux-watchdog-next. Kind regards, Wim.