From: Olaf Hering Subject: Re: [PATCH] tools: set migration constraints from cmdline Date: Mon, 4 Feb 2013 14:09:39 +0100 Message-ID: <20130204130939.GA16090@aepfle.de> References: <577b051fca174be9f7b3.1359394360@probook.site> <1359556230.12252.235.camel@zakaz.uk.xensource.com> <20130204095709.GB2564@aepfle.de> <1359982485.7743.11.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1359982485.7743.11.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Mon, Feb 04, Ian Campbell wrote: > On Mon, 2013-02-04 at 09:57 +0000, Olaf Hering wrote: > > On Wed, Jan 30, Ian Campbell wrote: > > > > > On Mon, 2013-01-28 at 17:32 +0000, Olaf Hering wrote: > > > > A variant of this change has been tested with xend, the patch below is > > > > only compile tested. The changes to libxl change the API, is that > > > > approach acceptable? > > > > > > I'm afraid not, the compatibility requirements are covered in the > > > comment near the top of libxl.h. > > > > > > So you either need a new function or to leverage the LIBXL_API_VERSION > > > define (which the user must supply) such that people providing 0x040200 > > > see the current interface and people providing 0x040300 (or nothing) see > > > the new one. > > > > And to avoid the API change at all, should max_iters and max_factor be > > passed via xenstore to xc_domain_save()? So that either the caller of > > xc_domain_save reads the values from xenstore, or the function itself > > reads it from there. What do you think? > > Unfortunately libxc cannot access xenstore. In case of xm, it would be the xc_save binary, which can receive both values from argv[]. In case of xl, it would be a xenstore write in main_migrate and a read in libxl_domain_suspend. Which would cover also other callers of libxl_domain_suspend. Olaf