From: Olaf Hering Subject: Re: [PATCH v4] tools: set migration constraints from cmdline Date: Mon, 4 Feb 2013 14:55:53 +0100 Message-ID: <20130204135553.GB16668@aepfle.de> References: <577b051fca174be9f7b3.1359394360@probook.site> <785c8f34e1f802106e53.1359747275@probook.site> <1359983463.7743.23.camel@zakaz.uk.xensource.com> <20130204134102.GC16090@aepfle.de> <1359985584.7743.39.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1359985584.7743.39.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Mon, Feb 04, Ian Campbell wrote: > > Instead the migration should be aborted and the guest should continue to > > run on the old host. > > That's what I understood from reading the code, can we make the docs say > it too ;-) -A --abort-if-busy maybe? > > > > =item B [I] I I > > > > diff -r fd711ebdce9a -r 785c8f34e1f8 tools/libxc/xc_domain_save.c > > > > --- a/tools/libxc/xc_domain_save.c > > > > +++ b/tools/libxc/xc_domain_save.c > > > > > > The changes to this file only seem to implement the -N and not the other > > > two? > > > > xc_domain_save already has max_iters and max_factor as arguments. > > Ah, I didn't appreciate that. > > BTW did you want to add a way to override DEF_MIN_REMAINING? I did consider it, but havent looked closer how to do it. > I'm not really sure what the usecase is for save -c. I'd be a bit > inclined to leave it until someone wants it I think. save -c looks like a snapshot feature, but does not seem to take storage into accound. So yes, I will leave it alone. Olaf