From: Joerg Roedel Subject: Re: [PATCH 4/5] iommu: Add domain window handling functions Date: Tue, 5 Feb 2013 14:20:45 +0100 Message-ID: <20130205132044.GB2532@8bytes.org> References: <1359983924-28952-1-git-send-email-joro@8bytes.org> <1359983924-28952-5-git-send-email-joro@8bytes.org> <20130204185650.GP25591@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Stuart Yoder Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Mon, Feb 04, 2013 at 05:31:51PM -0600, Stuart Yoder wrote: > On Mon, Feb 4, 2013 at 12:56 PM, Joerg Roedel wrote: > > On Mon, Feb 04, 2013 at 12:10:51PM -0600, Stuart Yoder wrote: > >> On Mon, Feb 4, 2013 at 7:18 AM, Joerg Roedel wrote: > >> > +static inline int iommu_domain_window_enable(struct iommu_domain *domain, > >> > + u32 wnd_nr, phys_addr_t paddr, > >> > + size_t size) > >> > +{ > >> > + return -ENODEV; > >> > +} > >> > + > >> > +static inline void iommu_domain_window_disable(struct iommu_domain *domain, > >> > + u32 wnd_nr) > >> > +{ > >> > +} > >> > + > >> > static inline phys_addr_t iommu_iova_to_phys(struct iommu_domain *domain, > >> > unsigned long iova) > >> > { > >> > >> This API looks workable. The one change we need is that the size argument in > >> the enable API needs to be 64 bits. Our window sizes can exceed 4GB. > > > > Okay. So if your architecture supports sizes over 2^32 then size_t > > probably is already 64bits, right? > > No, on a 32-bit platform size_t would generally be 32-bits. But the PAMU > is independent of that. I think we should just make it a u64. Okay, I will change that. Will push the updated branch once Sethi agrees on the interface changes. Joerg