From: Eric Wong Subject: Re: [RFC] fuse: consistently use readdirplus offsets Date: Wed, 6 Feb 2013 21:40:41 +0000 Message-ID: <20130206214041.GA27531@dcvr.yhbt.net> References: <87mx1ngmip.fsf@tucsk.pomaz.szeredi.hu> <1358220208-27131-1-git-send-email-steve.shuo.feng@gmail.com> <1358220208-27131-3-git-send-email-steve.shuo.feng@gmail.com> <20130203071534.GA12174@dcvr.yhbt.net> <20130203081024.GA19271@dcvr.yhbt.net> <20130204101048.GA4514@dcvr.yhbt.net> <20130205031202.GA9062@dcvr.yhbt.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Feng Shuo , fuse-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, Miklos Szeredi , Anand Avati To: Miklos Szeredi Return-path: Received: from dcvr.yhbt.net ([64.71.152.64]:36214 "EHLO dcvr.yhbt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754926Ab3BFVkl (ORCPT ); Wed, 6 Feb 2013 16:40:41 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Miklos Szeredi wrote: > On Tue, Feb 5, 2013 at 4:12 AM, Eric Wong wrote: > > Miklos Szeredi wrote: > >> I think the problem is that directory offsets are not consistent > >> between readdir and readdirplus. The solution is that userspace > >> should always use the same offsets. This makes the readdirplus > >> implementation more complex but that's really the only sane thing to > >> do. > > > > I think something like the following is necessary in the kernel, too. > > (Userspace patch coming) > > Can you please explain what this patch is trying to do? Because I > think it's not doing what it wants ;) I admit I'm not sure why your original email only said: userspace should always use the same offsets instead of: kernel and userspace should always use the same offsets This patch makes the kernel always use the same offsets, as does v2 of my high-level userspace patch. Anyways, I've tested this patch together with my v2 userspace patch and got the results I expected with adaptive readdirplus. Perhaps I have two bugs nullifying each other?