From: Wolfgang Denk Date: Thu, 07 Feb 2013 11:21:25 +0100 Subject: [U-Boot] [PATCH 02/11] Blackfin: bf60x: Port blackfin core architecture code to boot on bf60x. In-Reply-To: <1360223258-6945-3-git-send-email-sonic.adi@gmail.com> References: <1360223258-6945-1-git-send-email-sonic.adi@gmail.com> <1360223258-6945-3-git-send-email-sonic.adi@gmail.com> Message-ID: <20130207102125.B8730200565@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Sonic Zhang, In message <1360223258-6945-3-git-send-email-sonic.adi@gmail.com> you wrote: > From: Sonic Zhang > > Set up clocks, DDR controller, Nor flash controller, reboot, > serial port. Add new SPI boot modes. Checkpatch issues, please fix. > +#ifndef __ADSPBF60x__ > +#include > +#else > +#include > +#endif General question: you add a _lot_ of new #ifdef's all over the place. Also, I think I see lots of duplicated (or very similar) code. Can this not be avoided? > if (BFIN_DEBUG_EARLY_SERIAL) { > - int ucen = bfin_read16(&pUART->gctl) & UCEN; > + int enabled = serial_early_enabled(uart_base); > serial_early_init(uart_base); Please spearate declarations and code by a blankline. Please fix globally (at least where you touch the code anyway). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Successful and fortunate crime is called virtue. - Seneca