From: Wolfgang Denk Date: Sat, 09 Feb 2013 07:54:20 +0100 Subject: [U-Boot] [PATCH] CONFIG_BOOTDELAY default should not affect runtime In-Reply-To: <1360355280-1197-1-git-send-email-joe.hershberger@ni.com> References: <1360355280-1197-1-git-send-email-joe.hershberger@ni.com> Message-ID: <20130209065420.22507200539@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Joe Hershberger, In message <1360355280-1197-1-git-send-email-joe.hershberger@ni.com> you wrote: > Because the code that handles bootdelay is compiled in conditionally > based on the default value, you are restricted in the default, > regardless of what you want the runtime options to be. > > Change the source to always check if any default is given so that other > values can be selected and used at runtime. > > Signed-off-by: Joe Hershberger > --- > common/main.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/common/main.c b/common/main.c > index e2d2e09..0973c59 100644 > --- a/common/main.c > +++ b/common/main.c > @@ -95,7 +95,7 @@ extern void mdm_init(void); /* defined in board.c */ > * Watch for 'delay' seconds for autoboot stop or autoboot delay string. > * returns: 0 - no key string, allow autoboot 1 - got key string, abort > */ > -#if defined(CONFIG_BOOTDELAY) && (CONFIG_BOOTDELAY >= 0) > +#if defined(CONFIG_BOOTDELAY) Careful!! This is probably changing behaviour of a number of boards significantly. we have to check if we really want this, and if yes, we have to announce it and provide a grace period (eventually using doc/feature-removal-schedule.txt ?) Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Nail here --X-- for new monitor.