From: wsa@the-dreams.de (Wolfram Sang) Date: Thu, 21 Feb 2013 11:48:10 +0100 Subject: [PATCH] i2c: Remove unneeded xxx_set_drvdata(..., NULL) calls In-Reply-To: <1360970315-32116-1-git-send-email-dianders@chromium.org> References: <1360953682-25066-1-git-send-email-dianders@chromium.org> <1360970315-32116-1-git-send-email-dianders@chromium.org> Message-ID: <20130221104810.GD22806@the-dreams.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Feb 15, 2013 at 03:18:35PM -0800, Doug Anderson wrote: > There is simply no reason to be manually setting the private driver > data to NULL in the remove/fail to probe cases. This is just extra > cruft code that can be removed. > > A few notes: > * Nothing relies on drvdata being set to NULL. > * The __device_release_driver() function eventually calls > dev_set_drvdata(dev, NULL) anyway, so there's no need to do it > twice. > * I verified that there were no cases where xxx_get_drvdata() was > being called in these drivers and checking for / relying on the NULL > return value. > > This could be cleaned up kernel-wide but for now just take the baby > step and remove from the i2c subsystem. > > Reported-by: Wolfram Sang > Reported-by: Stephen Warren > Signed-off-by: Doug Anderson Applied, thanks!