From: Tim Deegan Subject: Re: [PATCH V2 27/46] xen: arm: arm64 trap handling. Date: Thu, 21 Feb 2013 16:07:45 +0000 Message-ID: <20130221160745.GC24051@ocelot.phlegethon.org> References: <1360860465.20449.472.camel@zakaz.uk.xensource.com> <1360860480-9245-27-git-send-email-ian.campbell@citrix.com> <20130221151023.GT24051@ocelot.phlegethon.org> <1361460324.26546.62.camel@zakaz.uk.xensource.com> <20130221153650.GY24051@ocelot.phlegethon.org> <1361462564.26546.76.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1361462564.26546.76.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Stefano Stabellini , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org At 16:02 +0000 on 21 Feb (1361462564), Ian Campbell wrote: > On Thu, 2013-02-21 at 15:36 +0000, Tim Deegan wrote: > > At 15:25 +0000 on 21 Feb (1361460324), Ian Campbell wrote: > > > On Thu, 2013-02-21 at 15:10 +0000, Tim Deegan wrote: > > > > At 16:47 +0000 on 14 Feb (1360860461), Ian Campbell wrote: > > > > > Signed-off-by: Ian Campbell > > > > > --- > > > > > v2: Call leave_hypervisor_tail on exit back to guest, disable interrupts while > > > > > restoring state. > > > > > > > > You don't seem to have addressed my other comments on v1: > > > > > > I've got them in v3, I noted that I hadn't addresses you comment on this > > > patch in the #0/46. > > > > So you did; I did read the 0/46, but for some reason all that stuck in > > my head was the WFE stuff. > > > > AFAICS you just need to re-roll this and #25, > > I don't think you mean #25? That is "xen: arm64: add guest type to > domain field." which you've acked. Sorry, I meant #5. > When I'm applying my own patches I prefer to do it from the list rather > than short cutting them from my own tree, keep me honest/from making > mistakes. How about I include an index of acked/unacked patches in the > zeroeth mail? You ought to be able to just mark it all as read. Fair enough -- no need to index them; I just keep all previous versions of a series around so I can easily find the comments. But this won't need a v4, will it? :) Tim.