From: Scott Wood Date: Fri, 22 Feb 2013 19:59:41 -0600 Subject: [U-Boot] [PATCHv2 3/4] env_nand.c: clarify log messages when env reading fails In-Reply-To: <1361467316-29044-4-git-send-email-phil.sutter@viprinet.com> References: <1353502761-12640-1-git-send-email-phil.sutter@viprinet.com> <1361467316-29044-1-git-send-email-phil.sutter@viprinet.com> <1361467316-29044-4-git-send-email-phil.sutter@viprinet.com> Message-ID: <20130223015941.GA10876@home.buserror.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Feb 21, 2013 at 06:21:55PM +0100, Phil Sutter wrote: > The single message is misleading, since there is no equivalent success > note when reading the other copy succeeds. Instead, warn if one of the > redundant copies could not be loaded and emphasise on the error when > reading both fails. > > Signed-off-by: Phil Sutter > --- > common/env_nand.c | 12 ++++++++---- > 1 files changed, 8 insertions(+), 4 deletions(-) Applied to u-boot-nand-flash. > - if (readenv(CONFIG_ENV_OFFSET_REDUND, (u_char *) tmp_env2)) > - puts("No Valid Redundant Environment Area found\n"); > + if (read1_fail && read2_fail) > + puts("*** Error - No Valid Environment Area found\n"); > + else if (read1_fail || read2_fail) > + puts("*** Warning - some problems detected " > + "reading environment; recovered successfully\n"); > > crc1_ok = crc32(0, tmp_env1->data, ENV_SIZE) == tmp_env1->crc; > crc2_ok = crc32(0, tmp_env2->data, ENV_SIZE) == tmp_env2->crc; We should also give a message if one of the CRCs is bad, though that's an existing problem. -Scott