From: Guenter Roeck Date: Tue, 26 Feb 2013 19:41:33 +0000 Subject: Re: [lm-sensors] [PATCH v5 03/12] hwmon: (nct6775) Add support for temperature sensors Message-Id: <20130226194133.GA6240@roeck-us.net> List-Id: References: <1361903020-18526-1-git-send-email-linux@roeck-us.net> <1361903020-18526-4-git-send-email-linux@roeck-us.net> <1361903714.2023.19.camel@joe-AO722> In-Reply-To: <1361903714.2023.19.camel@joe-AO722> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Joe Perches Cc: Jean Delvare , lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org On Tue, Feb 26, 2013 at 10:35:14AM -0800, Joe Perches wrote: > On Tue, 2013-02-26 at 10:23 -0800, Guenter Roeck wrote: > > diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c > [] > > +static const u16 NCT6779_REG_TEMP_CONFIG[11] = { 0x18, 0x152 }; > > Isn't 11 too magic a number? > Yes; good catch. It actually doesn't need a size in the first place, as long as it has (at least) the same size as NCT677x_REG_TEMP. Must be a leftover from an earlier version of the code. Thanks, Guenter _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors