From: arnd@arndb.de (Arnd Bergmann) Date: Sat, 2 Mar 2013 22:12:38 +0000 Subject: [PATCH v4 1/2] dma: imx-dma: Add oftree support In-Reply-To: <1362243213-29399-2-git-send-email-mpa@pengutronix.de> References: <1362243213-29399-1-git-send-email-mpa@pengutronix.de> <1362243213-29399-2-git-send-email-mpa@pengutronix.de> Message-ID: <201303022212.38322.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Saturday 02 March 2013, Markus Pargmann wrote: > Adding devicetree support for imx-dma driver. Use driver name for > function 'imx_dma_is_general_purpose' because the devicename for > devicetree initialized devices is different. Just one small comment this time: > @@ -734,8 +757,9 @@ static int imxdma_alloc_chan_resources(struct dma_chan *chan) > struct imxdma_channel *imxdmac = to_imxdma_chan(chan); > struct imx_dma_data *data = chan->private; > > - if (data != NULL) > + if (data != NULL) { > imxdmac->dma_request = data->dma_request; > + } > > while (imxdmac->descs_allocated < IMXDMA_MAX_CHAN_DESCRIPTORS) { > struct imxdma_desc *desc; I assume that this change wasn't meant to be in here. Arnd