From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Fix missing variable initilization Date: Sun, 3 Mar 2013 18:20:26 +0100 Message-ID: <20130303172026.GG9021@phenom.ffwll.local> References: <1361745338-28522-1-git-send-email-s.syam@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f175.google.com (mail-we0-f175.google.com [74.125.82.175]) by gabe.freedesktop.org (Postfix) with ESMTP id E132BE5D38 for ; Sun, 3 Mar 2013 09:17:54 -0800 (PST) Received: by mail-we0-f175.google.com with SMTP id x8so3843736wey.6 for ; Sun, 03 Mar 2013 09:17:53 -0800 (PST) Content-Disposition: inline In-Reply-To: <1361745338-28522-1-git-send-email-s.syam@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Syam Sidhardhan Cc: daniel.vetter@ffwll.ch, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Mon, Feb 25, 2013 at 04:05:38AM +0530, Syam Sidhardhan wrote: > Need to initialize the variable wait to false. > > Signed-off-by: Syam Sidhardhan Looks sane, thanks for the patch. Cc'ing Paulo in case I've missed something. -Daniel > --- > drivers/gpu/drm/i915/intel_ddi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c > index fc95ef0..5d0a687 100644 > --- a/drivers/gpu/drm/i915/intel_ddi.c > +++ b/drivers/gpu/drm/i915/intel_ddi.c > @@ -1391,8 +1391,8 @@ void intel_ddi_prepare_link_retrain(struct drm_encoder *encoder) > struct intel_dp *intel_dp = &intel_dig_port->dp; > struct drm_i915_private *dev_priv = encoder->dev->dev_private; > enum port port = intel_dig_port->port; > - bool wait; > uint32_t val; > + bool wait = false; > > if (I915_READ(DP_TP_CTL(port)) & DP_TP_CTL_ENABLE) { > val = I915_READ(DDI_BUF_CTL(port)); > -- > 1.7.9.5 > -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch