From: Wolfgang Denk Date: Mon, 04 Mar 2013 10:24:32 +0100 Subject: [U-Boot] [PATCH] powerpc/85xx: Add workaround for errata USB-14 (enable on P204x/P3041/P50x0) In-Reply-To: <1362368146-738-1-git-send-email-B33228@freescale.com> References: <1362368146-738-1-git-send-email-B33228@freescale.com> Message-ID: <20130304092432.A4867200246@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear xulei, In message <1362368146-738-1-git-send-email-B33228@freescale.com> you wrote: > > + /* On P204x/P304x/P50x0 Rev1.0, USB transmit will result internal > + * multi-bit ECC errors, which has impact on performance, so software > + * should disable all ECC reporting from USB1 and USB2 by setting bits > + * 16 and 17 to 1 in the register at DCSRBASE + 0x0002_0520. > + */ > +#ifdef CONFIG_SYS_FSL_ERRATUM_USB14 > + if (IS_SVR_REV(get_svr(), 1, 0)) { > + void *p; > + p = (void *)CONFIG_SYS_DCSRBAR + 0x20520; > + setbits_be32(p, 3 << (31 - 17)); > + } > +#endif Please move the comment inside the #ifdef block. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de I distrust all systematisers, and avoid them. The will to a system shows a lack of honesty. - Friedrich Wilhelm Nietzsche _G?tzen-D?mmerung [The Twilight of the Idols]_ ``Maxims and Missiles'' no. 26