From: Nishanth Menon Subject: Re: [PATCH V2] drm/edid: kernel-doc minimal cleanup Date: Mon, 4 Mar 2013 10:27:33 -0600 Message-ID: <20130304162731.GA14287@kahuna> References: <1362146456-21077-1-git-send-email-nm@ti.com> <1362244180.6874.3.camel@mattotaupa> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by gabe.freedesktop.org (Postfix) with ESMTP id 86088E606A for ; Mon, 4 Mar 2013 08:27:35 -0800 (PST) Content-Disposition: inline In-Reply-To: <1362244180.6874.3.camel@mattotaupa> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Paul Menzel Cc: Dave Airlie , dri-devel , Rodrigo Vivi List-Id: dri-devel@lists.freedesktop.org On 18:09-20130302, Paul Menzel wrote: > Am Freitag, den 01.03.2013, 08:00 -0600 schrieb Nishanth Menon: > > Some basic cleanups for kernel-doc errors or missing documentation > > parameters. > = > Nishanth, thanks for doing that! glad to be of help. > = > > index c194f4e..bd864b5 100644 > > --- a/drivers/gpu/drm/drm_edid.c > > +++ b/drivers/gpu/drm/drm_edid.c > > @@ -982,14 +982,14 @@ EXPORT_SYMBOL(drm_edid_is_valid); > > = > > #define DDC_SEGMENT_ADDR 0x30 > > /** > > - * Get EDID information via I2C. > > - * > > - * \param adapter : i2c device adaptor > > - * \param buf : EDID data buffer to be filled > > - * \param len : EDID data buffer length > > - * \return 0 on success or -1 on failure. > > + * drm_do_probe_ddc_edid() - Get EDID information via I2C. > = > Some already existing entries do not use =BB()=AB behind the function name > in the comment. Not sure what the correct way is though. I followed the format as in: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documen= tation/kernel-doc-nano-HOWTO.txt#n55 That said, I might suggest someone more knowledgable than I look through the drm_edid.c - there seems to be code alignment issues etc which I did not fix up. running Lindent quickly shows: http://pastebin.com/vaYFQDHv -- = Regards, Nishanth Menon