From: Tom Rini Date: Mon, 4 Mar 2013 21:20:15 -0500 Subject: [U-Boot] [PATCH 4/4] ARM: atmel: add sama5d3xek support In-Reply-To: <5135528D.7050800@atmel.com> References: <1362034848-6371-1-git-send-email-voice.shen@atmel.com> <1362034848-6371-5-git-send-email-voice.shen@atmel.com> <20130304151459.GA25797@bill-the-cat> <5135528D.7050800@atmel.com> Message-ID: <20130305022015.GC16106@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Mar 05, 2013 at 10:03:57AM +0800, Bo Shen wrote: > Hi Tom, > > On 3/4/2013 23:14, Tom Rini wrote: > >On Thu, Feb 28, 2013 at 03:00:47PM +0800, Bo Shen wrote: [snip] > >>@@ -0,0 +1,268 @@ > >>+/* > >>+ * Configuation settings for the SAMA5D3xEK board. > >[snip] > >>+#undef CONFIG_USE_IRQ /* we don't need IRQ/FIQ stuff */ > >>+ > >>+#undef CONFIG_CMDLINE_TAG /* enable passing of ATAGs */ > >>+#undef CONFIG_SETUP_MEMORY_TAGS > >>+#undef CONFIG_INITRD_TAG > > > >Just leave these, and the other #undef's out. > > You mean I need not to #undef these, because these are not defined, > am I right? Correct. > > >>+/* > >>+ * Command line configuration. > >>+ */ > >>+#include > >>+#undef CONFIG_CMD_FPGA > >>+#undef CONFIG_CMD_IMI > >>+#undef CONFIG_CMD_IMLS > >>+#undef CONFIG_CMD_AUTOSCRIPT > >>+#undef CONFIG_CMD_LOADS > > > >These are fine to leave in 'tho. > > These are no useful for us. > I will consider remove unneeded #undef Right. > >And please check things with checkpatch.pl, I > >thought I saw a '#defineFOO' in there. Thanks! > > I have checked this patch with checkpatch.pl, and get no errors and > no warnings. OK, thanks. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: