From: Daniel Vetter Subject: Re: [PATCH] [v4] drm/i915: Capture current context on error Date: Tue, 5 Mar 2013 09:39:10 +0100 Message-ID: <20130305083910.GE9021@phenom.ffwll.local> References: <1361758202-1952-3-git-send-email-ben@bwidawsk.net> <1362445229-27787-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f175.google.com (mail-we0-f175.google.com [74.125.82.175]) by gabe.freedesktop.org (Postfix) with ESMTP id 7842DE5EA4 for ; Tue, 5 Mar 2013 00:36:38 -0800 (PST) Received: by mail-we0-f175.google.com with SMTP id x8so5711874wey.6 for ; Tue, 05 Mar 2013 00:36:37 -0800 (PST) Content-Disposition: inline In-Reply-To: <1362445229-27787-1-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Mar 04, 2013 at 05:00:29PM -0800, Ben Widawsky wrote: > On error, this represents the state of the currently running context at > the time it was loaded. > > Unfortunately, since we're hung and can't switch out the context this > may not tell us too much about the most current state of the context, > but does give clues about what has happened since loading. > > Thanks to recent doc updates, we have a little more confidence regarding > what is actually in this memory, and perhaps it will help us gain more > insight into certain bugs. AFAICT, the most interesting info is in the > first page. To save space, we only capture the first page. In the > future, we might want to dump more. > > Sample of the relevant part of error state: > render ring --- HW Context = 0x01b20000 > [0000] 00000000 1100105f 00002028 ffff0880 > [0010] 0000209c feff4040 000020c0 efdf0080 > [0020] 00002178 00000001 0000217c 00145855 > [0030] 00002310 00000000 00002314 00000000 > > v2: Move error collection to the ring error code > Change format of dump to not confuse intel_error_decode (Chris) > Put the context error object with the others (Chris) > Don't search bound_list instead of active_list (chris) > > v3: extract and flatten context recording (daniel) > checkpatch related fixes for the copypasta in debugfs > > v4: bug in v3 (Daniel) > - if ((ring->id == RCS) && error->ccid) > + if ((ring->id != RCS) || !error->ccid) Still a redundant () pair here ... I've killed it. > References: https://bugs.freedesktop.org/show_bug.cgi?id=55845 > Reviewed-by (v2): Chris Wilson > Signed-off-by: Ben Widawsky > Cc: Daniel Vetter Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch