From: Wolfgang Denk Date: Thu, 07 Mar 2013 07:57:13 +0100 Subject: [U-Boot] [PATCH v9 15/30] autoconfig.mk: Make it possible to define configs from other configs In-Reply-To: <1362596377-5827-15-git-send-email-benoit.thebaudeau@advansee.com> References: <1362596377-5827-1-git-send-email-benoit.thebaudeau@advansee.com> <1362596377-5827-15-git-send-email-benoit.thebaudeau@advansee.com> Message-ID: <20130307065713.D53D2200520@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Beno?t Th?baudeau, In message <1362596377-5827-15-git-send-email-benoit.thebaudeau@advansee.com> you wrote: > > + # ... and from configs defined from other configs > + s/="\(CONFIG_[A-Za-z0-9_][A-Za-z0-9_]*\)"/=$(\1)/; Should we not remove the lower case letters here? Such are not supposed to be used in macro names. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de If all you have is a hammer, everything looks like a nail.