From: Eric Wong Subject: Re: epoll: possible bug from wakeup_source activation Date: Sat, 9 Mar 2013 07:10:37 +0000 Message-ID: <20130309071037.GA13360@dcvr.yhbt.net> References: <20130307112639.GA25130@dcvr.yhbt.net> <20130308013027.GA31830@dcvr.yhbt.net> <20130308204944.GA27379@dcvr.yhbt.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: NeilBrown , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Davide Libenzi , Alexander Viro , linux-fsdevel@vger.kernel.org, Andrew Morton To: Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Arve Hj=C3=B8nnev=C3=A5g wrote: > On Fri, Mar 8, 2013 at 12:49 PM, Eric Wong wr= ote: > > What happens if ep_modify calls ep_destroy_wakeup_source > > while __pm_stay_awake is running on the same epi->ws? >=20 > Yes, that looks like a problem. I think calling > ep_destroy_wakeup_source with ep->lock held should fix that. It is no= t > clear how useful changing EPOLLWAKEUP in ep_modify is, so > alternatively we could remove that feature and instead only allow it > to be set in ep_insert. ep->lock would work, but ep->lock is already a source of heavy contention in my multithreaded+epoll webservers. Perhaps RCU can be used? I've no experience with RCU, but I've been meaning to get acquainted with RCU. Another possible solution is to only use ep->ws and add an atomic counter to ep; so __pm_relax(ep->ws) is only called when the atomic counter reaches zero.