From: Tom Rini Date: Thu, 14 Mar 2013 13:36:48 -0400 Subject: [U-Boot] [PATCH v4] Add initial support for Wandboard dual lite and solo. In-Reply-To: References: <1363228354-29534-1-git-send-email-festevam@gmail.com> <20130314123136.3A79E2005BB@gemini.denx.de> Message-ID: <20130314173648.GX23324@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Mar 14, 2013 at 02:01:20PM -0300, Fabio Estevam wrote: > Hi Wolfgang, > > On Thu, Mar 14, 2013 at 9:31 AM, Wolfgang Denk wrote: > > Dear Fabio Estevam, > > > > In message <1363228354-29534-1-git-send-email-festevam@gmail.com> you wrote: > >> From: Fabio Estevam > >> > >> Add initial support for Wandboard. > > > > Subject and commit message are redundant, resulting in text like this: > > > > Add initial support for Wandboard dual lite and solo. > > > > Add initial support for Wandboard. > > > > Please remove the second line. > > Thanks for the review. I will address your comments and send v5 after > the nitrogen patches are applied into u-boot.imx. > > >> +#define CONFIG_BOOTDELAY 1 > > > > Is there any reason for not chosing the more standard 5 second delay? > > Ok, so let's go with 3 seconds then ;-) There's a pretty even distribution of 1 3 and 5 second delays (with a few 10s, 2s and 6s). If they want 1, let them have 1, it's not hard to break into, you have U-Boot starting + 1sec. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: