From: Wolfgang Denk Date: Fri, 15 Mar 2013 18:27:41 +0100 Subject: [U-Boot] [PATCH v4] Add initial support for Wandboard dual lite and solo. In-Reply-To: <5143365F.5000207@denx.de> References: <1363228354-29534-1-git-send-email-festevam@gmail.com> <20130314123136.3A79E2005BB@gemini.denx.de> <20130314202406.5FE6520057D@gemini.denx.de> <5143365F.5000207@denx.de> Message-ID: <20130315172741.353A42005F7@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Stefano Babic, In message <5143365F.5000207@denx.de> you wrote: > > > Indeed this is common code, I see it now. So yes, if we change this, > > it should be done as separate patch. I think debug() makes a lot of > > sense here to reduce the output at boot time to a reasonable minimum, > > but then - is there another way for the user to inquire for this > > information. If not, should we add it to the bdinfo output? > > Reset cause is a very important information - we can know if the > processor gets a watchdog, or if a power on happened. The last one can > address to hiddden issues with the power supply. > > I understand that less redundant information is better, but this is very > important info and it cannot be used only if DEBUG is set. IMHO we > should let it as it is - it helps us when something bad happens. I agree that it is important information, and there should be a way that the user can get at this information. But I see no urgent need to print this for everyboot, where it is just costing us precious boot time (yes, it's only a few milliseconds, but they are trivial to save). That was why I suggested to add thjis information for example to the output of the "bdinfo" command. BTW: if I type "reset", I will get a message "Reset cause: WDOG". I know why, but most users will not know thy they see a watchdog reset here, so actually this information may be more confusing than helpful in a number of cases (which is IMO one more reason to not always to display it - it saves us a number of unproductive support requests). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de If today is the first day of the rest of your life, what the hell was yesterday?