From: Mukesh Rathor Subject: Re: [PATCH 4/18 V2]: PVH xen: add params to read_segment_register Date: Mon, 18 Mar 2013 17:23:23 -0700 Message-ID: <20130318172323.09ca23e9@mantra.us.oracle.com> References: <20130315172825.6b1982e3@mantra.us.oracle.com> <51470C2D02000078000C64E2@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51470C2D02000078000C64E2@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On Mon, 18 Mar 2013 11:44:29 +0000 "Jan Beulich" wrote: > >>> On 16.03.13 at 01:28, Mukesh Rathor > >>> wrote: > > --- a/xen/arch/x86/traps.c > > +++ b/xen/arch/x86/traps.c > > @@ -1823,7 +1823,7 @@ static inline uint64_t > > guest_misc_enable(uint64_t > > val) } > > \ (eip) += sizeof(_x); _x; }) > > -#define read_sreg(regs, sr) read_segment_register(sr) > > +#define read_sreg(vcpu, regs, sr) read_segment_register(vcpu, > > regs, sr) > > I don't see why you would need to retain this macro now that all > arguments get simply passed through. I figured they didn't use read_segment_register() in the first place, so may be will need to be changed again in future. I'll just get rid of it then and use read_segment_register(). thanks m