From: Chris Wilson Subject: Re: [PATCH v2 0/7] xfree86: Handle drm race condition Date: Tue, 19 Mar 2013 10:27:07 +0000 Message-ID: <20130319102707.GD3872@cantiga.alporthouse.com> References: <1363639911-21239-1-git-send-email-bryce@canonical.com> <20130319092146.GC3872@cantiga.alporthouse.com> <514837A6.5010301@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id C3815E5EB7 for ; Tue, 19 Mar 2013 03:27:30 -0700 (PDT) Content-Disposition: inline In-Reply-To: <514837A6.5010301@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Mar 19, 2013 at 11:02:14AM +0100, Maarten Lankhorst wrote: > Hey, > > Op 19-03-13 10:21, Chris Wilson schreef: > > On Mon, Mar 18, 2013 at 01:51:44PM -0700, Bryce Harrington wrote: > >> Update: Squashes a couple commits to avoid potential hang if > >> git bisecting. No other changes from v1. > > I'd probably drop the last EAGAIN patch as that is part of the libdrm > > API, but other than that it looks to be a reasonably self-contained w/a > > for this perplexing problem. > > > > Reviewed-by: Chris Wilson > > -Chris > > > And completely wrong, version I pushed to ubuntu's xorg-server for comparison: > > Nacked-by: Maarten Lankhorst So you pushed the busy-spin into drmSetMaster(), which is just a tighter variant of the above. Anything which adds the minimal delay, warns about that delay, and works around the issue is fine by me. -Chris -- Chris Wilson, Intel Open Source Technology Centre