From: Tim Deegan Subject: Re: [PATCH 8/8] evtchn: add FIFO-based event channel hypercalls and port ops Date: Wed, 20 Mar 2013 14:23:58 +0000 Message-ID: <20130320142358.GA95617@ocelot.phlegethon.org> References: <1363726818-25409-1-git-send-email-david.vrabel@citrix.com> <1363726818-25409-9-git-send-email-david.vrabel@citrix.com> <5149A1E602000078000C71C1@nat28.tlf.novell.com> <5149BCBA.4060106@citrix.com> <5149CDC802000078000C72EB@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <5149CDC802000078000C72EB@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Wei Liu , "xen-devel@lists.xen.org" , "Keir (Xen.org)" , David Vrabel , Konrad Rzeszutek Wilk List-Id: xen-devel@lists.xenproject.org At 13:55 +0000 on 20 Mar (1363787704), Jan Beulich wrote: > >>> On 20.03.13 at 14:42, David Vrabel wrote: > > On 20/03/13 10:47, Jan Beulich wrote: > >>>>> On 19.03.13 at 22:00, David Vrabel wrote: > >>> +struct evtchn_fifo_queue { > >>> + volatile uint32_t *head; /* points into control block */ > >> > >> I still think that explicit barriers are the way to go. Unless Linux'es > >> view on this has changed, you'll have issues getting the Linux folks > >> to accept this. > > > > This volatile can just be removed. head is only written by Xen in one > > place and it is immediately followed by a spin_unlock() which is a barrier. > > A release type barrier only, but that presumably is sufficient for > the purposes here. You might have to use an atomic_t or similar if the consumer might be confused by partial updates. Tim.