From: Wolfgang Denk Date: Thu, 21 Mar 2013 07:55:53 +0100 Subject: [U-Boot] [PATCH] Fix bootdelay timeout calculation when SYS_HZ!=1000 In-Reply-To: <1363842874-8286-1-git-send-email-swarren@wwwdotorg.org> References: <1363842874-8286-1-git-send-email-swarren@wwwdotorg.org> Message-ID: <20130321065553.BC624200547@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Stephen Warren, In message <1363842874-8286-1-git-send-email-swarren@wwwdotorg.org> you wrote: > Commit b2f3e0e "console: USB: KBD: Fix incorrect autoboot timeout" > re-wrote the bootdelay timeout loop. However, it hard-coded the value > that get_delay() was expected to increment in one second, rather than > calculating it based on CONFIG_SYS_HZ. On systems where SYS_HZ != 1000, > this caused bootdelay timeout to be incorrect. Fix this. Are there any such systems left? I agree with your patch, but if you know of systems that use incorrect values of CONFIG_SYS_HZ then please point these out so they can be fixed! A system with CONFIG_SYS_HZ != 1000 is _broken_. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de It is dangerous to be right on a subject on which the established authorities are wrong. -- Voltaire