From: Tim Deegan Subject: Re: [PATCH 5/18 V2]: PVH xen: more preparatory changes for PVH Date: Thu, 21 Mar 2013 15:58:37 +0000 Message-ID: <20130321155837.GL12338@ocelot.phlegethon.org> References: <20130315173027.470a3b18@mantra.us.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20130315173027.470a3b18@mantra.us.oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Mukesh Rathor Cc: "Xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org At 17:30 -0700 on 15 Mar (1363368627), Mukesh Rathor wrote: > This is another preparotary patch for PVH. In this patch, following > functions are made non-static: > vmx_fpu_enter(), get_instruction_length(), update_guest_eip(), > vmx_dr_access(), vmx_do_extint(), pv_cpuid(), and > emulate_forced_invalid_op(). > > There is no functionality change. > > Changes in V2: > - prepend vmx_ to get_instruction_length and update_guest_eip. > - Do not export/use vmr(). > > Signed-off-by: Mukesh Rathor Looks fine to me, but this change: > @@ -905,7 +905,7 @@ static int emulate_invalid_rdtscp(struct cpu_user_regs *regs) > return EXCRET_fault_fixed; > } > > -static int emulate_forced_invalid_op(struct cpu_user_regs *regs) > +unsigned long emulate_forced_invalid_op(struct cpu_user_regs *regs) > { > char sig[5], instr[2]; > unsigned long eip, rc; made me notice that the later patch where you make this function sometimes return an address is a bit worrying. Let me comment there directly... Tim.