From: Tim Deegan Subject: Re: [PATCH 10/18 V2]: PVH xen: introduce vmx_pvh.c and pvh.c Date: Fri, 22 Mar 2013 10:06:43 +0000 Message-ID: <20130322100643.GC25310@ocelot.phlegethon.org> References: <20130315174145.4bc0e78f@mantra.us.oracle.com> <20130321164912.GO12338@ocelot.phlegethon.org> <514C251702000078000C7ADA@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <514C251702000078000C7ADA@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: "Xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org At 08:32 +0000 on 22 Mar (1363941127), Jan Beulich wrote: > >>> On 21.03.13 at 17:49, Tim Deegan wrote: > >> + else if (cr == 3) { > >> + printk("PVH: d%d: unexpected cr3 access vmexit. rip:%lx\n", > > > >> + current->domain->domain_id, regs->rip); > >> + domain_crash_synchronous(); > > > > Again, ITYM BUG(). And again. probably a switch statement. > > Actually, in cases where just crashing the guest is safe (i.e. no > other execution state is corrupted), I think avoiding the use of > BUG() is quite desirable. I wouldn't mind an ASSERT() though, to > catch developers' attention. Ack, ASSERT() + crash is better. Tim.