From: Wolfgang Denk Date: Fri, 22 Mar 2013 21:54:11 +0100 Subject: [U-Boot] [PATCH 01/21] common: Update cmd_bdinfo for PPC In-Reply-To: <1363972995-25836-1-git-send-email-yorksun@freescale.com> References: <1363972995-25836-1-git-send-email-yorksun@freescale.com> Message-ID: <20130322205411.D51182014CE@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear York Sun, In message <1363972995-25836-1-git-send-email-yorksun@freescale.com> you wrote: > Add board detail function to print more individual board information. > > Signed-off-by: York Sun > --- > common/cmd_bdinfo.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/common/cmd_bdinfo.c b/common/cmd_bdinfo.c > index 85279d5..3bf8cf2 100644 > --- a/common/cmd_bdinfo.c > +++ b/common/cmd_bdinfo.c > @@ -84,6 +84,12 @@ static void print_mhz(const char *name, unsigned long hz) > } > > #if defined(CONFIG_PPC) > +static void __board_detail(void) > +{ > + /* Please define boot_detail() for your platform */ > +} This comment here is pretty much misleading. We are not suppoed to add any coe here, right? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Each team building another component has been using the most recent tested version of the integrated system as a test bed for debugging its piece. Their work will be set back by having that test bed change under them. Of course it must. But the changes need to be quantized. Then each user has periods of productive stability, interrupted by bursts of test-bed change. This seems to be much less disruptive than a constant rippling and trembling. - Frederick Brooks Jr., "The Mythical Man Month"