From: Wolfgang Denk Date: Fri, 22 Mar 2013 21:55:24 +0100 Subject: [U-Boot] [PATCH 07/21] net/fm: fixup ethernet for mEMAC In-Reply-To: <1363973052-25918-5-git-send-email-yorksun@freescale.com> References: <1363973052-25918-1-git-send-email-yorksun@freescale.com> <1363973052-25918-5-git-send-email-yorksun@freescale.com> Message-ID: <20130322205524.5DC4C2014CE@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear York Sun, In message <1363973052-25918-5-git-send-email-yorksun@freescale.com> you wrote: > From: Shengzhou Liu > > - set proper compatible property name for mEMAC. > - fixed ft_fixup_port for dual-role mEMAC, which will lead to > MAC node disabled incorrectly. > > Signed-off-by: Shengzhou Liu > --- > drivers/net/fm/fm.h | 2 ++ > drivers/net/fm/init.c | 24 ++++++++++++++++++++++++ > 2 files changed, 26 insertions(+) CHECK: Logical continuations should be on the previous line #143: FILE: drivers/net/fm/init.c:248: + if (((info->port == FM1_DTSEC9) && (PORT_IS_ENABLED(FM1_10GEC1))) + || ((info->port == FM1_DTSEC10) && (PORT_IS_ENABLED(FM1_10GEC2))) CHECK: Logical continuations should be on the previous line #144: FILE: drivers/net/fm/init.c:249: + || ((info->port == FM1_DTSEC10) && (PORT_IS_ENABLED(FM1_10GEC2))) + || ((info->port == FM1_10GEC1) && (PORT_IS_ENABLED(FM1_DTSEC9))) CHECK: Logical continuations should be on the previous line #145: FILE: drivers/net/fm/init.c:250: + || ((info->port == FM1_10GEC1) && (PORT_IS_ENABLED(FM1_DTSEC9))) + || ((info->port == FM1_10GEC2) && (PORT_IS_ENABLED(FM1_DTSEC10))) CHECK: Logical continuations should be on the previous line #147: FILE: drivers/net/fm/init.c:252: +#if (CONFIG_SYS_NUM_FMAN == 2) + || ((info->port == FM2_DTSEC9) && (PORT_IS_ENABLED(FM2_10GEC1))) CHECK: Logical continuations should be on the previous line #148: FILE: drivers/net/fm/init.c:253: + || ((info->port == FM2_DTSEC9) && (PORT_IS_ENABLED(FM2_10GEC1))) + || ((info->port == FM2_DTSEC10) && (PORT_IS_ENABLED(FM2_10GEC2))) CHECK: Logical continuations should be on the previous line #149: FILE: drivers/net/fm/init.c:254: + || ((info->port == FM2_DTSEC10) && (PORT_IS_ENABLED(FM2_10GEC2))) + || ((info->port == FM2_10GEC1) && (PORT_IS_ENABLED(FM2_DTSEC9))) CHECK: Logical continuations should be on the previous line #150: FILE: drivers/net/fm/init.c:255: + || ((info->port == FM2_10GEC1) && (PORT_IS_ENABLED(FM2_DTSEC9))) + || ((info->port == FM2_10GEC2) && (PORT_IS_ENABLED(FM2_DTSEC10))) Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Whoever undertakes to set himself up as a judge of Truth and Know- ledge is shipwrecked by the laughter of the gods." - Albert Einstein