From: Daniel Vetter Subject: Re: [PATCH] drm/i915: set dummy page for stolen objects Date: Sat, 23 Mar 2013 13:34:34 +0100 Message-ID: <20130323123434.GE9021@phenom.ffwll.local> References: <1363986644-4545-1-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f42.google.com (mail-ee0-f42.google.com [74.125.83.42]) by gabe.freedesktop.org (Postfix) with ESMTP id C793BE5DFE for ; Sat, 23 Mar 2013 05:31:47 -0700 (PDT) Received: by mail-ee0-f42.google.com with SMTP id b47so2685799eek.29 for ; Sat, 23 Mar 2013 05:31:46 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1363986644-4545-1-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Mar 22, 2013 at 11:10:44PM +0200, Imre Deak wrote: > This is needed since currently sg_for_each_page assumes that we have > a valid page in each sg item. It is only a real problem for > CONFIG_SPARSEMEM where the page is dereferenced, in other cases the > iterator works ok with an invalid page pointer. > > We can remove this workaround when we have fixed sg_page_iter to work on > scatterlists without backing pages. > > Signed-off-by: Imre Deak Queued for -next and pushed down with a rebase to avoid bisecting issues, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch