From: Torstein Hegge Subject: Re: [PATCH v5] ALSA: usb: Work around CM6631 sample rate change bug Date: Wed, 27 Mar 2013 13:46:32 +0100 Message-ID: <20130327124632.GF18838@pvv.ntnu.no> References: <20130326211004.GD18838@pvv.ntnu.no> <5152C53D.5060604@ladisch.de> <20130327114703.GE18838@pvv.ntnu.no> <5152DD6E.6040707@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from microbel.pvv.ntnu.no (microbel.pvv.ntnu.no [129.241.210.179]) by alsa0.perex.cz (Postfix) with ESMTP id DDD1126517B for ; Wed, 27 Mar 2013 13:46:36 +0100 (CET) Content-Disposition: inline In-Reply-To: <5152DD6E.6040707@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Daniel Mack Cc: Takashi Iwai , alsa-devel@alsa-project.org, Clemens Ladisch List-Id: alsa-devel@alsa-project.org On Wed, Mar 27, 2013 at 12:52:14 +0100, Daniel Mack wrote: > On 27.03.2013 12:47, Torstein Hegge wrote: > > On Wed, Mar 27, 2013 at 11:09:01 +0100, Clemens Ladisch wrote: > >> Torstein Hegge wrote: > >>> The C-Media CM6631 USB receiver doesn't respond to changes in sample rate > >>> while the interface is active. The same behavior is observed in other UAC2 > >>> hardware like the VIA VT1731. > >> > >> Might it be possible that these devices have reset the interface (see > >> UAC2 section 3.16.3), and that the driver hasn't noticed this because it > >> doesn't handle Active Alternate Setting Control interrupts? > > > > If that was the case, wouldn't the device be in altsetting zero after > > the sample rate set and not be able to output sound at all? And as long > > as the current altsetting supports the target sample rate as reported in > > /proc/asound/card1/stream0, Active Alternate Setting Control shouldn't > > have to be invoked. > > You could just try and catch that currently unhandled interrupt. We > should support that anyway at some point ... It doesn't look like snd_usb_mixer_interrupt_v2() is invoked on sample rate changes. As far as I can tell, that should be invoked on any interrupts, but it was never triggered, so I might be wrong. Torstein