Date: Mon, 1 Apr 2013 13:17:37 +0200
From: Henning Heinold <heinold@inf.fu-berlin.de>
To: openembedded-core@lists.openembedded.org
Cc: openembedded-core@lists.openembedded.org
Message-ID: <20130401111737.GA19595@mi.fu-berlin.de>
References: <1364807444-20977-1-git-send-email-hmatrjp@users.sourceforge.jp>
MIME-Version: 1.0
In-Reply-To: <1364807444-20977-1-git-send-email-hmatrjp@users.sourceforge.jp>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: Henning Heinold <heinold@mi.fu-berlin.de>
Subject: Re: [PATCH] pcmciautils: fix segmentation fault of pccardctl command
Precedence: list
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Apr 01, 2013 at 06:10:44PM +0900, Takeshi Hamasaki wrote:
> 
Hi,

nitpicking about spelling.

> This changes difinition of PCMCIAUTILS_VERSION to string from a multichacter constant to avoid segmentation fault of pccardctl command. 
               ^^^ 

> Signed-off-by: Takeshi Hamasaki <hmatrjp@users.sourceforge.jp>
> ---
>  meta/recipes-bsp/pcmciautils/pcmciautils.inc |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-bsp/pcmciautils/pcmciautils.inc b/meta/recipes-bsp/pcmciautils/pcmciautils.inc
> index 80271d6..0651236 100644
> --- a/meta/recipes-bsp/pcmciautils/pcmciautils.inc
> +++ b/meta/recipes-bsp/pcmciautils/pcmciautils.inc
> @@ -21,7 +21,7 @@ export udevrulesdir = "${nonarch_base_libdir}/udev/rules.d"
>  export UDEV = "1"
>  LD = "${CC}"
>  CFLAGS =+ "-I${S}/src"
> -CFLAGS =+ "-DPCMCIAUTILS_VERSION=\'${PV}\'"
> +CFLAGS =+ "-DPCMCIAUTILS_VERSION=\\"${PV}\\""
>  
>  PARALLEL_MAKE = ""
>  EXTRA_OEMAKE = "-e 'STRIP=echo' 'LIB_OBJS=-lc -lsysfs' 'LEX=flex'"
> -- 
> 1.7.10.4

Bye Henning