Received: from eggs.gnu.org ([208.118.235.92]:44169) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMgCA-0002jP-1g for qemu-devel@nongnu.org; Mon, 01 Apr 2013 10:58:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMgC8-00085K-87 for qemu-devel@nongnu.org; Mon, 01 Apr 2013 10:58:49 -0400 Received: from hall.aurel32.net ([2001:470:1f15:c4f::1]:52561) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMgC8-00085G-0K for qemu-devel@nongnu.org; Mon, 01 Apr 2013 10:58:48 -0400 Date: Mon, 1 Apr 2013 16:58:45 +0200 From: Aurelien Jarno Message-ID: <20130401145845.GE19864@ohm.aurel32.net> References: <1362443590-28191-1-git-send-email-rth@twiddle.net> <1362443590-28191-20-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1362443590-28191-20-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH v2 19/27] tcg-ppc64: Handle constant inputs for some compound logicals List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: av1474@comtv.ru, qemu-devel@nongnu.org On Mon, Mar 04, 2013 at 04:33:02PM -0800, Richard Henderson wrote: > Since we have special code to handle and/or/xor with a constant, > apply the same to andc/orc/eqv with a constant. > > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 44 ++++++++++++++++++++++++++++++++++---------- > 1 file changed, 34 insertions(+), 10 deletions(-) > > diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c > index a1be15a..c1d974b 100644 > --- a/tcg/ppc64/tcg-target.c > +++ b/tcg/ppc64/tcg-target.c > @@ -1388,17 +1388,19 @@ static void tcg_out_op (TCGContext *s, TCGOpcode opc, const TCGArg *args, > break; > > case INDEX_op_and_i32: > + a0 = args[0], a1 = args[1], a2 = args[2]; > if (const_args[2]) { > - tcg_out_andi32(s, args[0], args[1], args[2]); > + tcg_out_andi32(s, a0, a1, a2); > } else { > - tcg_out32(s, AND | SAB(args[1], args[0], args[2])); > + tcg_out32(s, AND | SAB(a1, a0, a2)); > } > break; > case INDEX_op_and_i64: > + a0 = args[0], a1 = args[1], a2 = args[2]; > if (const_args[2]) { > - tcg_out_andi64(s, args[0], args[1], args[2]); > + tcg_out_andi64(s, a0, a1, a2); > } else { > - tcg_out32(s, AND | SAB(args[1], args[0], args[2])); > + tcg_out32(s, AND | SAB(a1, a0, a2)); > } > break; > case INDEX_op_or_i64: > @@ -1420,14 +1422,36 @@ static void tcg_out_op (TCGContext *s, TCGOpcode opc, const TCGArg *args, > } > break; > case INDEX_op_andc_i32: > + a0 = args[0], a1 = args[1], a2 = args[2]; > + if (const_args[2]) { > + tcg_out_andi32(s, a0, a1, ~a2); > + } else { > + tcg_out32(s, ANDC | SAB(a1, a0, a2)); > + } > + break; > case INDEX_op_andc_i64: > - tcg_out32(s, ANDC | SAB(args[1], args[0], args[2])); > + a0 = args[0], a1 = args[1], a2 = args[2]; > + if (const_args[2]) { > + tcg_out_andi64(s, a0, a1, ~a2); > + } else { > + tcg_out32(s, ANDC | SAB(a1, a0, a2)); > + } > break; > case INDEX_op_orc_i32: > + if (const_args[2]) { > + tcg_out_ori32(s, args[0], args[1], ~args[2]); > + break; > + } > + /* FALLTHRU */ > case INDEX_op_orc_i64: > tcg_out32(s, ORC | SAB(args[1], args[0], args[2])); > break; > case INDEX_op_eqv_i32: > + if (const_args[2]) { > + tcg_out_xori32(s, args[0], args[1], ~args[2]); > + break; > + } > + /* FALLTHRU */ > case INDEX_op_eqv_i64: > tcg_out32(s, EQV | SAB(args[1], args[0], args[2])); > break; > @@ -1812,9 +1836,9 @@ static const TCGTargetOpDef ppc_op_defs[] = { > { INDEX_op_and_i32, { "r", "r", "ri" } }, > { INDEX_op_or_i32, { "r", "r", "ri" } }, > { INDEX_op_xor_i32, { "r", "r", "ri" } }, > - { INDEX_op_andc_i32, { "r", "r", "r" } }, > - { INDEX_op_orc_i32, { "r", "r", "r" } }, > - { INDEX_op_eqv_i32, { "r", "r", "r" } }, > + { INDEX_op_andc_i32, { "r", "r", "ri" } }, > + { INDEX_op_orc_i32, { "r", "r", "ri" } }, > + { INDEX_op_eqv_i32, { "r", "r", "ri" } }, > { INDEX_op_nand_i32, { "r", "r", "r" } }, > { INDEX_op_nor_i32, { "r", "r", "r" } }, > > @@ -1832,10 +1856,10 @@ static const TCGTargetOpDef ppc_op_defs[] = { > > { INDEX_op_add_i64, { "r", "r", "rTU" } }, > { INDEX_op_sub_i64, { "r", "rI", "rTU" } }, > - { INDEX_op_and_i64, { "r", "r", "rU" } }, > + { INDEX_op_and_i64, { "r", "r", "ri" } }, > { INDEX_op_or_i64, { "r", "r", "rU" } }, > { INDEX_op_xor_i64, { "r", "r", "rU" } }, > - { INDEX_op_andc_i64, { "r", "r", "r" } }, > + { INDEX_op_andc_i64, { "r", "r", "ri" } }, > { INDEX_op_orc_i64, { "r", "r", "r" } }, > { INDEX_op_eqv_i64, { "r", "r", "r" } }, > { INDEX_op_nand_i64, { "r", "r", "r" } }, Reviewed-by: Aurelien Jarno -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net