Received: from eggs.gnu.org ([208.118.235.92]:44217) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMgCK-00032U-0t for qemu-devel@nongnu.org; Mon, 01 Apr 2013 10:59:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMgCH-00087q-7O for qemu-devel@nongnu.org; Mon, 01 Apr 2013 10:58:59 -0400 Received: from hall.aurel32.net ([2001:470:1f15:c4f::1]:52564) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMgCH-00087d-0h for qemu-devel@nongnu.org; Mon, 01 Apr 2013 10:58:57 -0400 Date: Mon, 1 Apr 2013 16:58:54 +0200 From: Aurelien Jarno Message-ID: <20130401145854.GF19864@ohm.aurel32.net> References: <1362443590-28191-1-git-send-email-rth@twiddle.net> <1362443590-28191-21-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1362443590-28191-21-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH v2 20/27] tcg-ppc64: Implement deposit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: av1474@comtv.ru, qemu-devel@nongnu.org On Mon, Mar 04, 2013 at 04:33:03PM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 12 ++++++++++++ > tcg/ppc64/tcg-target.h | 4 ++-- > 2 files changed, 14 insertions(+), 2 deletions(-) > > diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c > index c1d974b..8114334 100644 > --- a/tcg/ppc64/tcg-target.c > +++ b/tcg/ppc64/tcg-target.c > @@ -1788,6 +1788,15 @@ static void tcg_out_op (TCGContext *s, TCGOpcode opc, const TCGArg *args, > } > break; > > + case INDEX_op_deposit_i32: > + tcg_out_rlw(s, RLWIMI, args[0], args[2], args[3], > + 32 - args[3] - args[4], 31 - args[3]); > + break; > + case INDEX_op_deposit_i64: > + tcg_out_rld(s, RLDIMI, args[0], args[2], args[3], > + 64 - args[3] - args[4]); > + break; > + > default: > tcg_dump_ops (s); > tcg_abort (); > @@ -1910,6 +1919,9 @@ static const TCGTargetOpDef ppc_op_defs[] = { > { INDEX_op_bswap32_i64, { "r", "r" } }, > { INDEX_op_bswap64_i64, { "r", "r" } }, > > + { INDEX_op_deposit_i32, { "r", "0", "r" } }, > + { INDEX_op_deposit_i64, { "r", "0", "r" } }, > + > { -1 }, > }; > > diff --git a/tcg/ppc64/tcg-target.h b/tcg/ppc64/tcg-target.h > index 35414cf..fed6740 100644 > --- a/tcg/ppc64/tcg-target.h > +++ b/tcg/ppc64/tcg-target.h > @@ -87,7 +87,7 @@ typedef enum { > #define TCG_TARGET_HAS_eqv_i32 1 > #define TCG_TARGET_HAS_nand_i32 1 > #define TCG_TARGET_HAS_nor_i32 1 > -#define TCG_TARGET_HAS_deposit_i32 0 > +#define TCG_TARGET_HAS_deposit_i32 1 > #define TCG_TARGET_HAS_movcond_i32 0 > #define TCG_TARGET_HAS_add2_i32 0 > #define TCG_TARGET_HAS_sub2_i32 0 > @@ -110,7 +110,7 @@ typedef enum { > #define TCG_TARGET_HAS_eqv_i64 1 > #define TCG_TARGET_HAS_nand_i64 1 > #define TCG_TARGET_HAS_nor_i64 1 > -#define TCG_TARGET_HAS_deposit_i64 0 > +#define TCG_TARGET_HAS_deposit_i64 1 > #define TCG_TARGET_HAS_movcond_i64 0 > #define TCG_TARGET_HAS_add2_i64 0 > #define TCG_TARGET_HAS_sub2_i64 0 Reviewed-by: Aurelien Jarno -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net