From: marex@denx.de (Marek Vasut) Date: Tue, 2 Apr 2013 01:16:04 +0200 Subject: [PATCH 4/5] spi/mxs: Remove bogus setting of ssp clk rate field In-Reply-To: <1364570381-17605-4-git-send-email-tpiepho@gmail.com> References: <1364570381-17605-1-git-send-email-tpiepho@gmail.com> <1364570381-17605-4-git-send-email-tpiepho@gmail.com> Message-ID: <201304020116.04781.marex@denx.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Dear Trent Piepho, > The ssp struct has a clock rate field, to provide the actual value, in Hz, > of the SSP output clock (the rate of SSP_SCK) after mxs_ssp_set_clk_rate() > is called. It should be read-only, except for mxs_ssp_set_clk_rate(). > > For some reason the spi-mxs driver decides to write to this field on init, > and sets it to the value of the SSP input clock (clk_sspN, from the MXS > clocking block) in kHz. It shouldn't be setting the value, and certainly > shouldn't be setting it with the wrong clock in the wrong units. I suspect this patch should also fix drivers/clk/mxs/clk-ssp.c then? > Signed-off-by: Trent Piepho > Cc: Marek Vasut > Cc: Fabio Estevam > Cc: Shawn Guo > --- > drivers/spi/spi-mxs.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c > index 7218006..fc52f78 100644 > --- a/drivers/spi/spi-mxs.c > +++ b/drivers/spi/spi-mxs.c > @@ -587,7 +587,6 @@ static int mxs_spi_probe(struct platform_device *pdev) > > clk_prepare_enable(ssp->clk); > clk_set_rate(ssp->clk, clk_freq); > - ssp->clk_rate = clk_get_rate(ssp->clk) / 1000; > > stmp_reset_block(ssp->base); Best regards, Marek Vasut