Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UNIj1-0003O6-NP for mharc-grub-devel@gnu.org; Wed, 03 Apr 2013 04:07:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNIix-0003Ig-Qa for grub-devel@gnu.org; Wed, 03 Apr 2013 04:07:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNIiv-0008QG-2Y for grub-devel@gnu.org; Wed, 03 Apr 2013 04:07:15 -0400 Received: from mail-wi0-x229.google.com ([2a00:1450:400c:c05::229]:57970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNIiu-0008Pt-S3 for grub-devel@gnu.org; Wed, 03 Apr 2013 04:07:12 -0400 Received: by mail-wi0-f169.google.com with SMTP id c10so4016778wiw.4 for ; Wed, 03 Apr 2013 01:07:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent:x-gm-message-state; bh=cLlY+efKwIJbgWAlq2r/qOCXgwtJo9KMMI1c69K7N+g=; b=K5nm2y+KDxVGTVRfxZ3NiuLvjGA2OrZiuQzR6f+NFs09DEuTeFuv1Jz33vPOHeUwUR GEIsE0rfPw0J9k7DzEHlf5itHfqSlY9OkvJv9815pgRUVAwm23Dcs4hpec88GdD4Tr/V 13gEW6qlDR+wyghb7mNc1ki2ymu90vwH0eRgU3aT3hACYdXiSxvDEvOXUS9flWlwDMQs bVawy3ITPCIRbXvisGcGfFYDfGPsCdVkflvvvMZLsyTvtKaNyIk56MSMxw/iC4bI7cUw aqNSA/8MnTAzsukKk3H+MMIknQ3Emfw6FIbsamkqN+Ft0FrzByFziihzlXEceJR5r9OI Ka/g== X-Received: by 10.194.173.228 with SMTP id bn4mr1139358wjc.20.1364976431808; Wed, 03 Apr 2013 01:07:11 -0700 (PDT) Received: from rocoto.smurfnet.nu ([2001:4b98:dc0:41:216:3eff:fea7:75f3]) by mx.google.com with ESMTPS id h10sm7285654wic.8.2013.04.03.01.07.09 (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 03 Apr 2013 01:07:11 -0700 (PDT) Date: Wed, 3 Apr 2013 08:07:41 +0000 From: Leif Lindholm To: The development of GNU GRUB Subject: Re: [PATCH] Add missing ARM relocation codes and fix existing ones Message-ID: <20130403080741.GD23069@rocoto.smurfnet.nu> References: <51462936.1020106@gmail.com> <5159B99C.9030304@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5159B99C.9030304@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-Gm-Message-State: ALoCoQntDWPAvVGcn8YQAHPeYQBimgHPTM4x1sRysnU/DpQYhcpLlqsS2cGXSjz5t4b8zHd+7BTM X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::229 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Apr 2013 08:07:18 -0000 On Mon, Apr 01, 2013 at 06:45:16PM +0200, Francesco Lavra wrote: > On 03/17/2013 09:36 PM, Francesco Lavra wrote: > > I'm working on the GRUB port to ARM using the EFI platform. When > > generating a relocatable ARM image, some relocation entries use a > > relocation code (0x33) which is not defined in include/grub/elf.h. So I > > went through the latest edition of the ELF specification for the ARM > > architecture (ARM IHI 0044E) and added the missing definitions to the > > header file. I also noticed some differences between the existing > > definitions and the spec: some relocation names are different from the > > spec, some definitions aren't in the spec at all, and one > > (R_ARM_IRELATIVE) has a different value than that from the spec. So > > while at it I fixed those differences as well. Hence this patch. > > Ping? > Do you see any merit in this patch? Apologies, was moving desks at the office, and moved my mailing list subscription to @linaro.org at the same time, so managed to miss this one completely. I'm happy for it to go in - it adds THM_JUMP19, which means I can drop that from my patches. / Leif