From: Wolfgang Denk Date: Sat, 06 Apr 2013 09:01:50 +0200 Subject: [U-Boot] [v3] command/cache: Add flush command In-Reply-To: <515F5812.8030008@freescale.com> References: <1365195056-20188-1-git-send-email-yorksun@freescale.com> <20130405220955.DC9BB2015C6@gemini.denx.de> <515F5812.8030008@freescale.com> Message-ID: <20130406070150.54B072002D9@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear York Sun, In message <515F5812.8030008@freescale.com> you wrote: > > > adding new: > > > > dcache flush => flush all > > dcache flush => flush range > > > > I think this makes more sense. Comments? > > It would if the command only deals with dcache. This command flushes > dcache _and_ invalidates icache. Then the name "flush" is even more a bad choice. > If "flush_cache" is acceptable, we can use v2. If not, please suggest > one. My candidates are "flushcache", "cacheflush". Can we not split this into: dcache flush icache invalidate ? This would make clear what's happening. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de READ THIS BEFORE OPENING PACKAGE: According to Certain Suggested Ver- sions of the Grand Unified Theory, the Primary Particles Constituting this Product May Decay to Nothingness Within the Next Four Hundred Million Years.