From: Andrew Morton Subject: Re: [PATCH] direct-io: Submit bio after boundary buffer is added to it Date: Tue, 9 Apr 2013 13:47:58 -0700 Message-ID: <20130409134758.fc074bcfda430b0ce6508d06@linux-foundation.org> References: <1365522169-24718-1-git-send-email-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, Kazuya Mio To: Jan Kara Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:39670 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754147Ab3DIUr7 (ORCPT ); Tue, 9 Apr 2013 16:47:59 -0400 In-Reply-To: <1365522169-24718-1-git-send-email-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, 9 Apr 2013 17:42:49 +0200 Jan Kara wrote: > Currently, dio_send_cur_page() submits bio before current page and > cached sdio->cur_page is added to the bio if sdio->boundary is set. This > is actually wrong because sdio->boundary means the current buffer is the > last one before metadata needs to be read. So we should rather submit > the bio after the current page is added to it. > > Reported-by: Kazuya Mio > Signed-off-by: Jan Kara > --- > fs/direct-io.c | 28 +++++++++++----------------- > 1 files changed, 11 insertions(+), 17 deletions(-) > > Andrew, can you add this patch the previous direct IO boundary handling fix? What is the user-visible impact of these two patches?