From: "J. Bruce Fields" Subject: Re: [PATCH 13/19] NFSD: Server implementation of MAC Labeling Date: Wed, 10 Apr 2013 11:19:53 -0400 Message-ID: <20130410151953.GC24404@pad.fieldses.org> References: <1364939160-20874-1-git-send-email-SteveD@redhat.com> <1364939160-20874-14-git-send-email-SteveD@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Trond Myklebust , "David P. Quigley" , Linux NFS list , Linux FS devel list , Linux Security List , SELinux List To: Steve Dickson Return-path: Content-Disposition: inline In-Reply-To: <1364939160-20874-14-git-send-email-SteveD-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Apr 02, 2013 at 05:45:54PM -0400, Steve Dickson wrote: > +__be32 nfsd4_set_nfs4_label(struct svc_rqst *rqstp, struct svc_fh *fhp, > + struct nfs4_label *label) > +{ > + return -EOPNOTSUPP; Anything that returns a __be32 is expecting nfserr_something, not -ERRNO. I made the same comment on a previous review: http://www.spinics.net/lists/linux-nfs/msg36104.html Please keep a careful list of these review comments! --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html