From: Tejun Heo Subject: Re: [PATCHSET] cgroup: implement task_cgroup_path_from_hierarchy() Date: Sun, 14 Apr 2013 20:22:33 -0700 Message-ID: <20130415032233.GI3050@htj.dyndns.org> References: <1365964619-14762-1-git-send-email-tj@kernel.org> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=2KwJsM0uCPMmNfKw9IlCVKpn+RqGJ5m/8xHawNI88Ic=; b=kpH2YCPVDh1jRsBzAX8wyH4QOpqO1+xnOtmnLARWOjGUtLsYsBMgXJqTrB5gGm6YaJ LQW+V3GhfAjjX3dTb1G7Zcuyb6v++2Se8mUZH7LPHi+y6AnqnL3iRDSqJ94a/jnVoU2n /9JZBBlob8UwVaExNd+siDgF+VxpnAC47fzERrqvgaosqjzDoAnbudMfThQnnbrnKNYk lY02sK1BU6pbOaGV5CK3wB2CPW3kH/U1zJWjYL39xPqFOjZjXEk1lRtieFC3V6d6EsUp 1lCXcf6Vtk+zAm8XWuTrSKpYg/Y5EgRL3+YlKnw0lpStTfs7Pd+xyG6hE81qf95QKrFt BfNA== Content-Disposition: inline In-Reply-To: <1365964619-14762-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kay-tD+1rO4QERM@public.gmane.org, greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org, lennart-mdGvqq1h2p+GdvJs77BJ7Q@public.gmane.org, daniel-cYrQPVfZoowdnm+yROfE0A@public.gmane.org On Sun, Apr 14, 2013 at 11:36:55AM -0700, Tejun Heo wrote: > kdbus folks want a sane way to determine the cgroup path that a given > task belongs to on a given hierarchy, which is a reasonble thing to > expect from cgroup core. > > This patchset make hierarchy_id allocation use idr instead of ida and > implement task_cgroup_path_from_hierarchy(). In the process, the > yucky ida cyclic allocation is replaced with idr_alloc_cyclic(). > > 0001-cgroup-refactor-hierarchy_id-handling.patch > 0002-cgroup-drop-hierarchy_id_lock.patch > 0003-cgroup-make-hierarchy_id-use-cyclic-idr.patch > 0004-cgroup-implement-task_cgroup_path_from_hierarchy.patch > > 0001-0002 prepare for conversion to idr, which 0003 does. > > 0004 implements the new function. > > This patchset is on top of next-20130412 as idr_alloc_cyclic() patch > is currently in -mm. Given that this isn't an urgent thing and the > merge window is just around the corner, it'd be probably best to route > these through cgroup/for-3.11 once v3.10-rc1 drops. > > These patches are also available in the following git branch. > > git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-task_cgroup_path_from_hierarchy > > And it actually reduces LOC. Woot Woot. > > include/linux/cgroup.h | 2 > kernel/cgroup.c | 128 +++++++++++++++++++++++++++++++++---------------- > 2 files changed, 89 insertions(+), 41 deletions(-) Heh, I must have been tripping or something. 89 > 41. It's still a lot cleaner tho. :) -- tejun