Received: from eggs.gnu.org ([208.118.235.92]:60967) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URfQy-0002it-UB for qemu-devel@nongnu.org; Mon, 15 Apr 2013 05:10:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URfQu-0000zB-2y for qemu-devel@nongnu.org; Mon, 15 Apr 2013 05:10:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11183) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URfQt-0000z5-QU for qemu-devel@nongnu.org; Mon, 15 Apr 2013 05:10:40 -0400 Date: Mon, 15 Apr 2013 11:09:43 +0200 From: Igor Mammedov Message-ID: <20130415110943.11449ec5@nial.usersys.redhat.com> In-Reply-To: <20130412192511.GX2719@otherpad.lan.raisama.net> References: <1365691918-30594-1-git-send-email-imammedo@redhat.com> <1365691918-30594-4-git-send-email-imammedo@redhat.com> <20130411174542.GF6862@otherpad.lan.raisama.net> <20130412131732.50cc00ef@thinkpad> <20130412192511.GX2719@otherpad.lan.raisama.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/19] cpu: make kvm-stub.o a part of CPU library List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: aliguori@us.ibm.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, lcapitulino@redhat.com, jfrei@linux.vnet.ibm.com, yang.z.zhang@intel.com, pbonzini@redhat.com, afaerber@suse.de, lig.fnst@cn.fujitsu.com, rth@twiddle.net On Fri, 12 Apr 2013 16:25:11 -0300 Eduardo Habkost wrote: > On Fri, Apr 12, 2013 at 01:17:32PM +0200, Igor Mammedov wrote: > [...] > > > [...] > > > > diff --git a/include/hw/pci/msi.h b/include/hw/pci/msi.h > > index d4d0450..c159a15 100644 > > --- a/include/hw/pci/msi.h > > +++ b/include/hw/pci/msi.h > > @@ -21,15 +21,15 @@ > > #ifndef QEMU_MSI_H > > #define QEMU_MSI_H > > > > -#ifndef CONFIG_USER_ONLY > > #include "qemu-common.h" > > By the way, have you tried to eliminate the qemu-common.h include above? > (not important now, but asking just in case you have tried and found issues) No, that would be just another bunch of not related cleanup patches. > > > -#include "hw/pci/pci.h" > > > > struct MSIMessage { > > uint64_t address; > > uint32_t data; > > }; > > > > +#ifndef CONFIG_USER_ONLY > > +#include "hw/pci/pci.h" > > extern bool msi_supported; > > > > void msi_set_message(PCIDevice *dev, MSIMessage msg); > > diff --git a/kvm-stub.c b/kvm-stub.c > > index 8cb81c4..b5d4446 100644 > > --- a/kvm-stub.c > > +++ b/kvm-stub.c > > @@ -123,7 +123,6 @@ int kvm_on_sigbus(int code, void *addr) > > return 1; > > } > > > > -#ifndef CONFIG_USER_ONLY > > int kvm_irqchip_add_msi_route(KVMState *s, MSIMessage msg) > > { > > return -ENOSYS; > > @@ -147,4 +146,3 @@ int kvm_irqchip_remove_irqfd_notifier(KVMState *s, > > EventNotifier *n, int virq) { > > return -ENOSYS; > > } > > -#endif > > > > > > > > -- > > > Eduardo > > > > > > -- > > Regards, > > Igor >