From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD) Date: Mon, 15 Apr 2013 18:00:41 +0200 Subject: [RFC patch 2/2] ARM: at91: cpuidle: move the driver to drivers/cpuidle directory In-Reply-To: <516C10C5.4050107@linaro.org> References: <1366032598-23053-1-git-send-email-daniel.lezcano@linaro.org> <1366032598-23053-3-git-send-email-daniel.lezcano@linaro.org> <20130415142047.GE15139@game.jcrosoft.org> <516C10C5.4050107@linaro.org> Message-ID: <20130415160041.GF15139@game.jcrosoft.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 16:37 Mon 15 Apr , Daniel Lezcano wrote: > On 04/15/2013 04:20 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > > On 15:29 Mon 15 Apr , Daniel Lezcano wrote: > >> We don't have any dependency with the SoC specific code. > >> > >> Move the driver to the drivers/cpuidle directory. > >> > >> Add Nicolas Ferre as author of the driver, so it will be in copy of the emails. > >> > >> Signed-off-by: Daniel Lezcano > > please use -M when generating the patch > > Oh, right. Thanks for reminding me the option. > > [ ... ] > > >> +#include > >> +#include > >> +#include > >> +#include > >> + > >> +#define AT91_MAX_STATES 2 > >> + > >> +extern void (*at91_standby_ops)(void); > > really don't like can we pass it via the pm? > > I agree, it is hackish. Can you elaborate when you say "pass it via the > pm" ? I was thinking about it I would even prefer to have a platfrom driver that pass it via platform data even in DT but not something that can touch globally and for drivers I prefer to do not use cpu_is only for the core Best Regards, J. > > > > -- > Linaro.org ? Open source software for ARM SoCs > > Follow Linaro: Facebook | > Twitter | > Blog >