From: Wolfgang Denk Date: Tue, 16 Apr 2013 07:34:32 +0200 Subject: [U-Boot] [PATCH 2/3] wandboard: Add support for carrier board MicroSD card In-Reply-To: References: <1366032948-9920-1-git-send-email-otavio@ossystems.com.br> <1366032948-9920-2-git-send-email-otavio@ossystems.com.br> Message-ID: <20130416053432.683A0200568@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Otavio Salvador, In message you wrote: > > > This should be an error. What about return -EINVAL ? > > Agreed, fixed locally. To make it more clear: this should be a compile-time error, not detected at runtime. > > With this change, you never return an error. > > Should we fail if *any* fail? Yes, this is the good old rule of defensive programming: as soon as you detect any kind of (critical) error, you print an error message and bail out. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "How to make a million dollars: First, get a million dollars." - Steve Martin