Return-path: Received: from kirsty.vergenet.net ([202.4.237.240]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1US6LD-0006ON-BQ for kexec@lists.infradead.org; Tue, 16 Apr 2013 13:54:36 +0000 Date: Tue, 16 Apr 2013 22:54:29 +0900 From: Simon Horman Subject: Re: [PATCH] Revert "kexec/powerpc: Handle buffer overflow in kernel command line" Message-ID: <20130416135429.GA4476@verge.net.au> References: <516D4B35.3060300@gmail.com> <516D4C5F.4020905@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <516D4C5F.4020905@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Zhang Yanfei Cc: "kexec@lists.infradead.org" T24gVHVlLCBBcHIgMTYsIDIwMTMgYXQgMDk6MDQ6MzFQTSArMDgwMCwgWmhhbmcgWWFuZmVpIHdy b3RlOgo+IEhpIFNpbW9uLAo+IAo+IEkgZm91bmQgdGhhdCB5b3UgbWF5IGFwcGx5IHRoZSBwYXRj aCBmcm9tIFN1enVraSB3aXRoIGEgd3JvbmcgY29tbWl0Cj4gZGVzY3JpcHRpb24gYnkgbWlzdGFr ZS4gU28gSSBzZW5kIHRoaXMgcmV2ZXJ0IHBhdGNoIGFuZCByZXNlbmQgdGhlCj4gcGF0Y2ggaW4g YW5vdGhlciBtYWlsIHdpdGggYSBzdWJqZWN0Ogo+ICAgICAiW1BBVENIIFJFU0VORF0ga2V4ZWMv cG93ZXJwYzogSGFuZGxlIGJ1ZmZlciBvdmVyZmxvdyBpbiBrZXJuZWwgY29tbWFuZCBsaW5lIgo+ IAo+IENvdWxkIHlvdSBwbGVhc2UgYXBwbHkgdGhlIHR3byBwYXRjaGVzPwoKU29ycnkgZm9yIG15 IGNhcmVsZXNzbmVzcy4KCkkgaGF2ZSByZW1vdmVkIHRoZSBwYXRjaCBJIGFwcGxpZWQgZWFybGll ciB0b2RheSwgYXBwbGllZCB0aGUKb25lIHlvdSBwb3N0ZWQgYWZ0ZXIgdGhpcyBvbmUgYW5kIGZv cmNpYmx5IHB1c2hlZCB0aGUgcmVzdWx0LgoKPiAKPiBUaGFua3MKPiBaaGFuZwo+IAo+IOS6jiAy MDEz5bm0MDTmnIgxNuaXpSAyMDo1OSwgWmhhbmcgWWFuZmVpIOWGmemBkzoKPiA+IEZyb206IFpo YW5nIFlhbmZlaSA8emhhbmd5YW5mZWlAY24uZnVqaXRzdS5jb20+Cj4gPiAKPiA+IFRoaXMgcmV2 ZXJ0cyBjb21taXQgZDU4ZGNhZTNlNjFiMzc1NTc4ZmYzMTQ1ZTYyN2E1ZDg1YWZiNWY1Mi4KPiA+ IAo+ID4gVGhlIGNvbW1pdCBkZXNjcmlwdGlvbiBpcyBraW5kIG9mIHdyb25nIGFuZCBtYXliZSBj YXVzZWQgYnkgU2ltb24KPiA+IHdoZW4gaGUgYXBwbGllZCB0aGUgcGF0Y2guCj4gPiAKPiA+IFNp Z25lZC1vZmYtYnk6IFpoYW5nIFlhbmZlaSA8emhhbmd5YW5mZWlAY24uZnVqaXRzdS5jb20+Cj4g PiAtLS0KPiA+ICBrZXhlYy9hcmNoL3BwYy9rZXhlYy1lbGYtcHBjLmMgICAgfCAgIDI5ICsrKysr KysrKysrKystLS0tLS0tLS0tLS0tLS0tCj4gPiAga2V4ZWMvYXJjaC9wcGMva2V4ZWMtdUltYWdl LXBwYy5jIHwgICAyMyArKysrKysrKystLS0tLS0tLS0tLS0tLQo+ID4gIDIgZmlsZXMgY2hhbmdl ZCwgMjIgaW5zZXJ0aW9ucygrKSwgMzAgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQg YS9rZXhlYy9hcmNoL3BwYy9rZXhlYy1lbGYtcHBjLmMgYi9rZXhlYy9hcmNoL3BwYy9rZXhlYy1l bGYtcHBjLmMKPiA+IGluZGV4IDk4Y2FlOWMuLjNkYWNhMmQgMTAwNjQ0Cj4gPiAtLS0gYS9rZXhl Yy9hcmNoL3BwYy9rZXhlYy1lbGYtcHBjLmMKPiA+ICsrKyBiL2tleGVjL2FyY2gvcHBjL2tleGVj LWVsZi1wcGMuYwo+ID4gQEAgLTE1Nyw3ICsxNTcsNyBAQCBpbnQgZWxmX3BwY19sb2FkKGludCBh cmdjLCBjaGFyICoqYXJndiwJY29uc3QgY2hhciAqYnVmLCBvZmZfdCBsZW4sCj4gPiAgCXN0cnVj dCBtZW1fZWhkciBlaGRyOwo+ID4gIAljaGFyICpjb21tYW5kX2xpbmUsICpjcmFzaF9jbWRsaW5l LCAqY21kbGluZV9idWY7Cj4gPiAgCWNoYXIgKnRtcF9jbWRsaW5lOwo+ID4gLQlpbnQgY29tbWFu ZF9saW5lX2xlbiwgY3Jhc2hfY21kbGluZV9sZW47Cj4gPiArCWludCBjb21tYW5kX2xpbmVfbGVu Owo+ID4gIAljaGFyICpkdGI7Cj4gPiAgCWludCByZXN1bHQ7Cj4gPiAgCWNoYXIgKmVycm9yX21z ZzsKPiA+IEBAIC0yNDQsMTAgKzI0NCwxOSBAQCBpbnQgZWxmX3BwY19sb2FkKGludCBhcmdjLCBj aGFyICoqYXJndiwJY29uc3QgY2hhciAqYnVmLCBvZmZfdCBsZW4sCj4gPiAgCX0gZWxzZSB7Cj4g PiAgCQljb21tYW5kX2xpbmUgPSBnZXRfY29tbWFuZF9saW5lKCk7Cj4gPiAgCX0KPiA+IC0JY29t bWFuZF9saW5lX2xlbiA9IHN0cmxlbihjb21tYW5kX2xpbmUpOwo+ID4gKwljb21tYW5kX2xpbmVf bGVuID0gc3RybGVuKGNvbW1hbmRfbGluZSkgKyAxOwo+ID4gIAo+ID4gIAlmaXh1cF9ub2Rlc1tj dXJfZml4dXBdID0gTlVMTDsKPiA+ICAKPiA+ICsJLyogTmVlZCB0byBhcHBlbmQgc29tZSBjb21t YW5kIGxpbmUgcGFyYW1ldGVycyBpbnRlcm5hbGx5IGluIGNhc2Ugb2YKPiA+ICsJICogdGFraW5n IGNyYXNoIGR1bXBzLgo+ID4gKwkgKi8KPiA+ICsJaWYgKGluZm8tPmtleGVjX2ZsYWdzICYgS0VY RUNfT05fQ1JBU0gpIHsKPiA+ICsJCWNyYXNoX2NtZGxpbmUgPSB4bWFsbG9jKENPTU1BTkRfTElO RV9TSVpFKTsKPiA+ICsJCW1lbXNldCgodm9pZCAqKWNyYXNoX2NtZGxpbmUsIDAsIENPTU1BTkRf TElORV9TSVpFKTsKPiA+ICsJfSBlbHNlCj4gPiArCQljcmFzaF9jbWRsaW5lID0gTlVMTDsKPiA+ ICsKPiA+ICAJLyogUGFyc2UgdGhlIEVsZiBmaWxlICovCj4gPiAgCXJlc3VsdCA9IGJ1aWxkX2Vs Zl9leGVjX2luZm8oYnVmLCBsZW4sICZlaGRyLCAwKTsKPiA+ICAJaWYgKHJlc3VsdCA8IDApIHsK PiA+IEBAIC0yODMsMjMgKzI5MiwxNiBAQCBpbnQgZWxmX3BwY19sb2FkKGludCBhcmdjLCBjaGFy ICoqYXJndiwJY29uc3QgY2hhciAqYnVmLCBvZmZfdCBsZW4sCj4gPiAgCQlnb3RvIG91dDsKPiA+ ICAJfQo+ID4gIAo+ID4gLQkvKgo+ID4gLQkgKiBOZWVkIHRvIGFwcGVuZCBzb21lIGNvbW1hbmQg bGluZSBwYXJhbWV0ZXJzIGludGVybmFsbHkgaW4gY2FzZSBvZgo+ID4gLQkgKiB0YWtpbmcgY3Jh c2ggZHVtcHMuIEFkZGl0aW9uYWwgc2VnbWVudHMgbmVlZCB0byBiZSBjcmVhdGVkLgo+ID4gKwkv KiBJZiBwYW5pYyBrZXJuZWwgaXMgYmVpbmcgbG9hZGVkLCBhZGRpdGlvbmFsIHNlZ21lbnRzIG5l ZWQKPiA+ICsJICogdG8gYmUgY3JlYXRlZC4KPiA+ICAJICovCj4gPiAgCWlmIChpbmZvLT5rZXhl Y19mbGFncyAmIEtFWEVDX09OX0NSQVNIKSB7Cj4gPiAtCQljcmFzaF9jbWRsaW5lID0geG1hbGxv YyhDT01NQU5EX0xJTkVfU0laRSk7Cj4gPiAtCQltZW1zZXQoKHZvaWQgKiljcmFzaF9jbWRsaW5l LCAwLCBDT01NQU5EX0xJTkVfU0laRSk7Cj4gPiAgCQlyZXN1bHQgPSBsb2FkX2NyYXNoZHVtcF9z ZWdtZW50cyhpbmZvLCBjcmFzaF9jbWRsaW5lLAo+ID4gIAkJCQkJCW1heF9hZGRyLCAwKTsKPiA+ ICAJCWlmIChyZXN1bHQgPCAwKSB7Cj4gPiAgCQkJcmVzdWx0ID0gLTE7Cj4gPiAgCQkJZ290byBv dXQ7Cj4gPiAgCQl9Cj4gPiAtCQljcmFzaF9jbWRsaW5lX2xlbiA9IHN0cmxlbihjcmFzaF9jbWRs aW5lKTsKPiA+IC0JfSBlbHNlIHsKPiA+IC0JCWNyYXNoX2NtZGxpbmUgPSBOVUxMOwo+ID4gLQkJ Y3Jhc2hfY21kbGluZV9sZW4gPSAwOwo+ID4gIAl9Cj4gPiAgCj4gPiAgCS8qCj4gPiBAQCAtMzM1 LDExICszMzcsNiBAQCBpbnQgZWxmX3BwY19sb2FkKGludCBhcmdjLCBjaGFyICoqYXJndiwJY29u c3QgY2hhciAqYnVmLCBvZmZfdCBsZW4sCj4gPiAgCj4gPiAgCWluZm8tPmVudHJ5ID0gKHZvaWQg KilhcmdfYmFzZTsKPiA+ICAjZWxzZQo+ID4gLQlpZiAoY3Jhc2hfY21kbGluZV9sZW4gKyBjb21t YW5kX2xpbmVfbGVuICsgMSA+IENPTU1BTkRfTElORV9TSVpFKSB7Cj4gPiAtCQlwcmludGYoIktl cm5lbCBjb21tYW5kIGxpbmUgZXhjZWVkcyBzaXplXG4iKTsKPiA+IC0JCXJldHVybiAtMTsKPiA+ IC0JfQo+ID4gLQo+ID4gIAljbWRsaW5lX2J1ZiA9IHhtYWxsb2MoQ09NTUFORF9MSU5FX1NJWkUp Owo+ID4gIAltZW1zZXQoKHZvaWQgKiljbWRsaW5lX2J1ZiwgMCwgQ09NTUFORF9MSU5FX1NJWkUp Owo+ID4gIAlpZiAoY29tbWFuZF9saW5lKQo+ID4gZGlmZiAtLWdpdCBhL2tleGVjL2FyY2gvcHBj L2tleGVjLXVJbWFnZS1wcGMuYyBiL2tleGVjL2FyY2gvcHBjL2tleGVjLXVJbWFnZS1wcGMuYwo+ ID4gaW5kZXggMDA4NDYzYi4uOTExM2ZiZSAxMDA2NDQKPiA+IC0tLSBhL2tleGVjL2FyY2gvcHBj L2tleGVjLXVJbWFnZS1wcGMuYwo+ID4gKysrIGIva2V4ZWMvYXJjaC9wcGMva2V4ZWMtdUltYWdl LXBwYy5jCj4gPiBAQCAtODIsNyArODIsNyBAQCBzdGF0aWMgaW50IHBwY19sb2FkX2JhcmVfYml0 cyhpbnQgYXJnYywgY2hhciAqKmFyZ3YsIGNvbnN0IGNoYXIgKmJ1ZiwKPiA+ICB7Cj4gPiAgCWNo YXIgKmNvbW1hbmRfbGluZSwgKmNtZGxpbmVfYnVmLCAqY3Jhc2hfY21kbGluZTsKPiA+ICAJY2hh ciAqdG1wX2NtZGxpbmU7Cj4gPiAtCWludCBjb21tYW5kX2xpbmVfbGVuLCBjcmFzaF9jbWRsaW5l X2xlbjsKPiA+ICsJaW50IGNvbW1hbmRfbGluZV9sZW47Cj4gPiAgCWNoYXIgKmR0YjsKPiA+ICAJ dW5zaWduZWQgaW50IGFkZHI7Cj4gPiAgCXVuc2lnbmVkIGxvbmcgZHRiX2FkZHI7Cj4gPiBAQCAt MTc4LDM0ICsxNzgsMjkgQEAgc3RhdGljIGludCBwcGNfbG9hZF9iYXJlX2JpdHMoaW50IGFyZ2Ms IGNoYXIgKiphcmd2LCBjb25zdCBjaGFyICpidWYsCj4gPiAgCj4gPiAgCWFkZF9zZWdtZW50KGlu Zm8sIGJ1ZiwgbGVuLCBsb2FkX2FkZHIsIGxlbiArIF8xTWlCKTsKPiA+ICAKPiA+IC0KPiA+ICAJ aWYgKGluZm8tPmtleGVjX2ZsYWdzICYgS0VYRUNfT05fQ1JBU0gpIHsKPiA+ICAgICAgICAgICAg ICAgICAgY3Jhc2hfY21kbGluZSA9IHhtYWxsb2MoQ09NTUFORF9MSU5FX1NJWkUpOwo+ID4gICAg ICAgICAgICAgICAgICBtZW1zZXQoKHZvaWQgKiljcmFzaF9jbWRsaW5lLCAwLCBDT01NQU5EX0xJ TkVfU0laRSk7Cj4gPiArICAgICAgICB9IGVsc2UKPiA+ICsgICAgICAgICAgICAgICAgY3Jhc2hf Y21kbGluZSA9IE5VTEw7Cj4gPiArCj4gPiArCWlmIChpbmZvLT5rZXhlY19mbGFncyAmIEtFWEVD X09OX0NSQVNIKSB7Cj4gPiAgCQlyZXQgPSBsb2FkX2NyYXNoZHVtcF9zZWdtZW50cyhpbmZvLCBj cmFzaF9jbWRsaW5lLAo+ID4gIAkJCQkJCW1heF9hZGRyLCAwKTsKPiA+ICAJCWlmIChyZXQgPCAw KSB7Cj4gPiAgCQkJcmV0ID0gLTE7Cj4gPiAgCQkJZ290byBvdXQ7Cj4gPiAgCQl9Cj4gPiAtCQlj cmFzaF9jbWRsaW5lX2xlbiA9IHN0cmxlbihjcmFzaF9jbWRsaW5lKTsKPiA+IC0JfSBlbHNlIHsK PiA+IC0JCWNyYXNoX2NtZGxpbmUgPSBOVUxMOwo+ID4gLQkJY3Jhc2hfY21kbGluZV9sZW4gPSAw Owo+ID4gLQl9Cj4gPiAtCj4gPiAtCWlmIChjcmFzaF9jbWRsaW5lX2xlbiArIGNvbW1hbmRfbGlu ZV9sZW4gKyAxID4gQ09NTUFORF9MSU5FX1NJWkUpIHsKPiA+IC0JCXByaW50ZigiS2VybmVsIGNv bW1hbmQgbGluZSBleGNlZWRzIG1heGltdW0gcG9zc2libGUgbGVuZ3RoXG4iKTsKPiA+IC0JCXJl dHVybiAtMTsKPiA+ICAJfQo+ID4gIAo+ID4gIAljbWRsaW5lX2J1ZiA9IHhtYWxsb2MoQ09NTUFO RF9MSU5FX1NJWkUpOwo+ID4gIAltZW1zZXQoKHZvaWQgKiljbWRsaW5lX2J1ZiwgMCwgQ09NTUFO RF9MSU5FX1NJWkUpOwo+ID4gLQo+ID4gIAlpZiAoY29tbWFuZF9saW5lKQo+ID4gLQkJc3RyY3B5 KGNtZGxpbmVfYnVmLCBjb21tYW5kX2xpbmUpOwo+ID4gKwkJc3RybmNhdChjbWRsaW5lX2J1Ziwg Y29tbWFuZF9saW5lLCBjb21tYW5kX2xpbmVfbGVuKTsKPiA+ICAJaWYgKGNyYXNoX2NtZGxpbmUp Cj4gPiAtCQlzdHJuY2F0KGNtZGxpbmVfYnVmLCBjcmFzaF9jbWRsaW5lLCBjcmFzaF9jbWRsaW5l X2xlbik7Cj4gPiArCQlzdHJuY2F0KGNtZGxpbmVfYnVmLCBjcmFzaF9jbWRsaW5lLAo+ID4gKwkJ CXNpemVvZihjcmFzaF9jbWRsaW5lKSAtCj4gPiArCQkJc3RybGVuKGNyYXNoX2NtZGxpbmUpIC0g MSk7Cj4gPiAgCj4gPiAgCWVsZl9yZWxfYnVpbGRfbG9hZChpbmZvLCAmaW5mby0+cmhkciwgKGNv bnN0IGNoYXIgKilwdXJnYXRvcnksCj4gPiAgCQkJCXB1cmdhdG9yeV9zaXplLCAwLCAtMSwgLTEs IDApOwo+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K a2V4ZWMgbWFpbGluZyBsaXN0CmtleGVjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9rZXhlYwo=