From: Wolfgang Denk Date: Tue, 16 Apr 2013 17:14:55 +0200 Subject: [U-Boot] [PATCH] make hang() a weak function In-Reply-To: <516D62E1.7090306@gmail.com> References: <1366107249-24547-1-git-send-email-andreas.devel@googlemail.com> <20130416133621.40db0a42@lilith> <516D39CF.9020907@gmail.com> <20130416122229.BB9E0200568@gemini.denx.de> <516D4B00.9030102@gmail.com> <20130416130515.04A83200568@gemini.denx.de> <516D52EE.1040402@gmail.com> <516D5D0A.20403@gmail.com> <20130416142358.E6CDA200568@gemini.denx.de> <516D62E1.7090306@gmail.com> Message-ID: <20130416151455.E6554200568@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Andreas, In message <516D62E1.7090306@gmail.com> you wrote: > > But how about other places in u-boot hang()ing the device? How can we > tell the user that state without a terminal? If one plugs a uart cable > he might see some cause of the hang() but this is not acceptable for > some groups of users. > Is it wise to completely stop a device without showing the state to the > user? If you want to tell the user, this should be done _before_ calling hang() - if you decide to hang() your board. Keep in mind that you don't have to define CONFIG_PANIC_HANG. Also, as done in arch/powerpc/lib/board.c we usually print an error message on the console device, and we can call bootstage_error(), which could initialte such actions. > This question is a bit hypothetical cause we should eliminate the root > causes for hang()s before going to market. However I would like to hear > your thoughts about that. You cannot eliminate all causes that will lead a board to run into hang(). There may be simply broken hardware, for example... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de F u cn rd ths u cnt spl wrth a dm!