Return-Path: Received: from mail-we0-f175.google.com ([74.125.82.175]:53698 "EHLO mail-we0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754426Ab3DRJ5X (ORCPT ); Thu, 18 Apr 2013 05:57:23 -0400 Received: by mail-we0-f175.google.com with SMTP id t11so2138406wey.34 for ; Thu, 18 Apr 2013 02:57:22 -0700 (PDT) From: Jack Morgenstein To: "Michael S. Tsirkin" Subject: Re: [PATCH repost for-3.9] pci: avoid work_on_cpu for nested SRIOV probes Date: Thu, 18 Apr 2013 12:57:50 +0300 Cc: Tejun Heo , Or Gerlitz , Ming Lei , Greg Kroah-Hartman , David Miller , Roland Dreier , netdev , Yan Burman , Bjorn Helgaas , linux-pci@vger.kernel.org References: <20130411153030.GA22743@redhat.com> <201304181240.10239.jackm@dev.mellanox.co.il> <20130418084832.GA16728@redhat.com> In-Reply-To: <20130418084832.GA16728@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Message-Id: <201304181257.50915.jackm@dev.mellanox.co.il> Sender: linux-pci-owner@vger.kernel.org List-ID: On Thursday 18 April 2013 11:48, Michael S. Tsirkin wrote: > On Thu, Apr 18, 2013 at 12:40:09PM +0300, Jack Morgenstein wrote: > > On Thursday 18 April 2013 11:33, Michael S. Tsirkin wrote: > > > But for pci_sriov_enable, the situation is actually very simple: > > > VFs almost never use the same driver as the PF so the warning > > > is bogus there. > > > > > What about the case where the VF driver IS the same as the PF driver? > > Then it can deadlock, e.g. if driver takes a global mutex. But it's an > internal driver issue the, you can trigger a deadlock through hardware > too, e.g. if VF initialization blocks until PF is fully initialized. > I think it's not the case for Mellanox, is it? Correct, the Mellanox driver does not deadlock. > This is what I refer to: would be nice to fix nested probing in general > but it seems disabling the warning is the best we can do for 3.9 since > it causes false positives. > >