From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915: report Gen5+ CPU and PCH FIFO underruns Date: Fri, 19 Apr 2013 09:34:15 +0200 Message-ID: <20130419073415.GO6169@phenom.ffwll.local> References: <1365800278-3781-1-git-send-email-przanoni@gmail.com> <1366316957.3790.4.camel@ideak-mobl> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 22806E5C86 for ; Fri, 19 Apr 2013 00:31:15 -0700 (PDT) Received: by mail-ee0-f49.google.com with SMTP id b47so628336eek.8 for ; Fri, 19 Apr 2013 00:31:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1366316957.3790.4.camel@ideak-mobl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Imre Deak Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Thu, Apr 18, 2013 at 11:29:17PM +0300, Imre Deak wrote: > On Fri, 2013-04-12 at 17:57 -0300, Paulo Zanoni wrote: > > +static void cpt_set_fifo_underrun_reporting(struct drm_device *dev, > > + enum transcoder pch_transcoder, > > + bool enable) > > +{ > > + struct drm_i915_private *dev_priv = dev->dev_private; > > + > > + if (enable) { > > + if (!cpt_can_enable_serr_int(dev)) > > + return; > > + > > + I915_WRITE(SERR_INT, SERR_INT_TRANS_A_FIFO_UNDERRUN | > > + SERR_INT_TRANS_B_FIFO_UNDERRUN | > > + SERR_INT_TRANS_C_FIFO_UNDERRUN); > > We end up here for LPT too, but there only the TRANS_A bit is defined. We have the same issue on cpt where there's not really a pipe C on the pch. I guess it doesn't really matter. > Otherwise looks good: > Reviewed-by: Imre Deak Queued for -next, thanks for the patch and review. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch